From 83d18b74c1bd9475c815ffca2546f2d7a82c8577 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 14 Nov 2025 18:20:08 -0800 Subject: [PATCH] [llvm] Delete pointers without null checks (NFC) Identified with readability-delete-null-pointer. --- llvm/include/llvm/ADT/ConcurrentHashtable.h | 6 ++---- llvm/lib/Target/Hexagon/HexagonHazardRecognizer.h | 5 +---- llvm/lib/Transforms/Vectorize/VPlan.cpp | 3 +-- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/llvm/include/llvm/ADT/ConcurrentHashtable.h b/llvm/include/llvm/ADT/ConcurrentHashtable.h index 9ee5f594ea56a..4e27bc48f9d1f 100644 --- a/llvm/include/llvm/ADT/ConcurrentHashtable.h +++ b/llvm/include/llvm/ADT/ConcurrentHashtable.h @@ -342,10 +342,8 @@ class ConcurrentHashTableByPtr { CurBucket.Size = NewBucketSize; // Delete old bucket entries. - if (SrcHashes != nullptr) - delete[] SrcHashes; - if (SrcEntries != nullptr) - delete[] SrcEntries; + delete[] SrcHashes; + delete[] SrcEntries; } uint32_t getBucketIdx(hash_code Hash) { return Hash & HashMask; } diff --git a/llvm/lib/Target/Hexagon/HexagonHazardRecognizer.h b/llvm/lib/Target/Hexagon/HexagonHazardRecognizer.h index 0528cbd1f15f5..683feb11c1422 100644 --- a/llvm/lib/Target/Hexagon/HexagonHazardRecognizer.h +++ b/llvm/lib/Target/Hexagon/HexagonHazardRecognizer.h @@ -50,10 +50,7 @@ class HexagonHazardRecognizer : public ScheduleHazardRecognizer { const HexagonSubtarget &ST) : Resources(ST.createDFAPacketizer(II)), TII(HII) { } - ~HexagonHazardRecognizer() override { - if (Resources) - delete Resources; - } + ~HexagonHazardRecognizer() override { delete Resources; } /// This callback is invoked when a new block of instructions is about to be /// scheduled. The hazard state is set to an initialized state. diff --git a/llvm/lib/Transforms/Vectorize/VPlan.cpp b/llvm/lib/Transforms/Vectorize/VPlan.cpp index 62dacf912e210..f99f51d5846cf 100644 --- a/llvm/lib/Transforms/Vectorize/VPlan.cpp +++ b/llvm/lib/Transforms/Vectorize/VPlan.cpp @@ -884,8 +884,7 @@ VPlan::~VPlan() { } for (VPValue *VPV : getLiveIns()) delete VPV; - if (BackedgeTakenCount) - delete BackedgeTakenCount; + delete BackedgeTakenCount; } VPIRBasicBlock *VPlan::getExitBlock(BasicBlock *IRBB) const {