-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[PowerPC] cost modeling for length type VP intrinsic load/store #168938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2fa5e1e
fd8d758
5d98a9b
5c7d0b1
000794a
1e54b21
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,10 @@ using namespace llvm; | |
|
|
||
| #define DEBUG_TYPE "ppctti" | ||
|
|
||
| static cl::opt<bool> PPCEVL("ppc-evl", | ||
| cl::desc("Allow EVL type vp.load/vp.store"), | ||
| cl::init(false), cl::Hidden); | ||
|
|
||
| static cl::opt<bool> Pwr9EVL("ppc-pwr9-evl", | ||
| cl::desc("Allow vp.load and vp.store for pwr9"), | ||
| cl::init(false), cl::Hidden); | ||
|
|
@@ -1078,3 +1082,65 @@ PPCTTIImpl::getVPLegalizationStrategy(const VPIntrinsic &PI) const { | |
|
|
||
| return VPLegalization(VPLegalization::Legal, VPLegalization::Legal); | ||
| } | ||
|
|
||
| bool PPCTTIImpl::hasActiveVectorLength() const { | ||
| unsigned CPU = ST->getCPUDirective(); | ||
| if (!PPCEVL) | ||
| return false; | ||
| if (CPU == PPC::DIR_PWR10 || CPU == PPC::DIR_PWR_FUTURE || | ||
| (Pwr9EVL && CPU == PPC::DIR_PWR9)) | ||
| return true; | ||
| return false; | ||
| } | ||
|
|
||
| bool PPCTTIImpl::isLegalMaskedLoad(Type *DataType, Align Alignment, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it looks the function
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are target hooks - methods defined in TargetTransformInfo in Analysis to give info to opt passes about target characteristics, which we override to provide PPC specific answers. We can't change the names. |
||
| unsigned AddressSpace) const { | ||
| if (!hasActiveVectorLength()) | ||
| return false; | ||
| auto IsLegalLoadWithLengthType = [](EVT VT) { | ||
| if (VT != MVT::i64 && VT != MVT::i32 && VT != MVT::i16 && VT != MVT::i8) | ||
| return false; | ||
| return true; | ||
| }; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: add a blank after the line for more readable. |
||
| return IsLegalLoadWithLengthType(TLI->getValueType(DL, DataType, true)); | ||
| } | ||
|
|
||
| bool PPCTTIImpl::isLegalMaskedStore(Type *DataType, Align Alignment, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do not think the function
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is exposed to external users. It is conceptually used in the patch through getMaskedMemoryOpCost but since it is currently the same as for load I didn't differentiate. I guess I can make this clearer by calling both from there. |
||
| unsigned AddressSpace) const { | ||
| return isLegalMaskedLoad(DataType, Alignment, AddressSpace); | ||
| } | ||
|
|
||
| InstructionCost | ||
| PPCTTIImpl::getMaskedMemoryOpCost(const MemIntrinsicCostAttributes &MICA, | ||
| TTI::TargetCostKind CostKind) const { | ||
| Type *DataTy = MICA.getDataType(); | ||
| Align Alignment = MICA.getAlignment(); | ||
| unsigned Opcode = MICA.getID() == Intrinsic::masked_load ? Instruction::Load | ||
| : Instruction::Store; | ||
| unsigned AddressSpace = MICA.getAddressSpace(); | ||
|
|
||
| InstructionCost BaseCost = BaseT::getMaskedMemoryOpCost(MICA, CostKind); | ||
|
|
||
| auto VecTy = dyn_cast<FixedVectorType>(DataTy); | ||
| if (!VecTy) | ||
| return BaseCost; | ||
| if (Opcode == Instruction::Load) { | ||
| if (!isLegalMaskedLoad(VecTy->getScalarType(), Alignment, AddressSpace)) | ||
| return BaseCost; | ||
| } else { | ||
| if (!isLegalMaskedStore(VecTy->getScalarType(), Alignment, AddressSpace)) | ||
| return BaseCost; | ||
| } | ||
| if (VecTy->getPrimitiveSizeInBits() > 128) | ||
| return BaseCost; | ||
|
|
||
| // Cost is 1 (scalar compare) + 1 (scalar select) + | ||
| // 1 * vectorCostAdjustmentFactor (vector load with length) | ||
| // Maybe + 1 (scalar shift) | ||
| InstructionCost Cost = 1 + 1 + | ||
| vectorCostAdjustmentFactor(Opcode, DataTy, nullptr); | ||
| if (ST->getCPUDirective() != PPC::DIR_PWR_FUTURE || | ||
| VecTy->getScalarSizeInBits() != 8) | ||
| Cost += 1; // need shift for length | ||
| return Cost; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ; RUN: opt < %s -mcpu=pwr9 -passes="print<cost-model>" 2>&1 -disable-output | FileCheck %s --check-prefix=P9 | ||
| ; RUN: opt < %s -mcpu=pwr10 -ppc-evl -passes="print<cost-model>" 2>&1 -disable-output | FileCheck %s --check-prefix=P10 | ||
| ; RUN: opt < %s -mcpu=future -ppc-evl -passes="print<cost-model>" 2>&1 -disable-output | FileCheck %s --check-prefix=FUTURE | ||
| target datalayout = "e-m:e-Fn32-i64:64-i128:128-n32:64-S128-v256:256:256-v512:512:512" | ||
| target triple = "powerpc64le-unknown-linux-gnu" | ||
|
|
||
| define void @bar(ptr %base, <2 x i8> %val) { | ||
| ; P9: cost of 16 for {{.*}} @llvm.masked.load.v2i8.p0 | ||
| ; P10: cost of 4 for {{.*}} @llvm.masked.load.v2i8.p0 | ||
| ; FUTURE: cost of 3 for {{.*}} @llvm.masked.load.v2i8.p0 | ||
| ; P9: cost of 12 for {{.*}} @llvm.masked.store.v2i8.p0 | ||
| ; P10: cost of 4 for {{.*}} @llvm.masked.store.v2i8.p0 | ||
| ; FUTURE: cost of 3 for {{.*}} @llvm.masked.store.v2i8.p0 | ||
| %x2 = call <2 x i8> @llvm.masked.load.v2i8.p0(ptr %base, i32 1, <2 x i1> <i1 1, i1 1>, <2 x i8> %val) | ||
|
|
||
| call void @llvm.masked.store.v2i8.p0(<2 x i8> %x2, ptr %base, i32 1, <2 x i1> <i1 1, i1 1>) | ||
|
Comment on lines
+14
to
+16
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you should cover at least all supported types + some unsupported ones |
||
|
|
||
| ret void | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could just be
This means vector predication intrinsics are supported? This would need some tests with vp intrinsics, which are different to masked ones used in the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can only do EVL vp.load and vp.store. When I tried an example it didn't look like LV used the generic intrinsic path for those.