Skip to content

[offload][lit] Fix compilation of two offload tests #169399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2025
+3 −3
Merged

[offload][lit] Fix compilation of two offload tests #169399

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad855dc
[offload][lit] Fix compilation of two offload tests
sarnex Nov 24, 2025
3dd7c24
address feedback
sarnex Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion offload/test/offloading/shared_lib_fp_mapping.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include <stdio.h>

extern int func(); // Provided in liba.so, returns 42
extern int func(void); // Provided in liba.so, returns 42
typedef int (*fp_t)();
Copy link
Contributor

@kevinsala kevinsala Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the typedef?

Copy link
Member Author

@sarnex sarnex Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using SPIR-V to repro the issue and it compiled successfully with just the func change.

Copy link
Contributor

@kevinsala kevinsala Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need the void in the typedef too, otherwise it's a type mismatch. Most compilers will accept it. Clang just reports a warning.

Copy link
Member Author

@sarnex sarnex Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in latest commit, thanks!


int main() {
Expand Down
2 changes: 1 addition & 1 deletion offload/test/offloading/static_linking.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ int foo() {
}
#else
#include <stdio.h>
int foo();
int foo(void);

int main() {
int x = foo();
Expand Down
Loading