Skip to content

[Offloading] Extend OffloadBinary format to support multiple metadata entries #169425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[Offloading] Extend OffloadBinary format to support multiple metadata entries #169425

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce7ab76
[Offloading] Extend OffloadBinary format to support multiple metadata…
YuriPlyakhin Nov 24, 2025
f66ae8c
updated offloadbinary per discussion
YuriPlyakhin Nov 25, 2025
98ad7e9
Minimal changes to make build and lit tests pass with new OffloadBina…
YuriPlyakhin Nov 26, 2025
a28aa79
Just a snapshot of work in progress.
YuriPlyakhin Nov 27, 2025
df65ae9
one more minor change to make build pass for now
YuriPlyakhin Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions llvm/include/llvm/Object/OffloadBinary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class OffloadBinary : public Binary {
using string_iterator_range = iterator_range<string_iterator>;

/// The current version of the binary used for backwards compatibility.
static const uint32_t Version = 1;
static const uint32_t Version = 2;

/// The offloading metadata that will be serialized to a memory buffer.
struct OffloadingImage {
Expand Down Expand Up @@ -109,9 +109,12 @@ class OffloadBinary : public Binary {
struct Header {
uint8_t Magic[4] = {0x10, 0xFF, 0x10, 0xAD}; // 0x10FF10AD magic bytes.
uint32_t Version = OffloadBinary::Version; // Version identifier.
uint64_t Size; // Size in bytes of this entire binary.
uint64_t EntryOffset; // Offset of the metadata entry in bytes.
uint64_t EntrySize; // Size of the metadata entry in bytes.
uint64_t Size; // Size in bytes of this entire binary.
uint64_t EntriesCount; // Number of metadata entries in the binary.
Copy link
Contributor

@jhuber6 jhuber6 Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with changing this, it wasn't really used for anything but a sanity check during parsing

uint64_t EntriesOffset; // Offset in bytes to the start of entries block.
uint64_t EntriesSize; // Size of the entries block in bytes.
uint64_t StringOffset; // Offset in bytes to the global string map
uint64_t NumStrings; // Number of entries in the global string map.
};

struct Entry {
Expand All @@ -127,6 +130,7 @@ class OffloadBinary : public Binary {
struct StringEntry {
uint64_t KeyOffset;
uint64_t ValueOffset;
uint64_t ValueSize; // Size of the value in bytes.
};

private:
Expand Down
Loading