Skip to content

[clang][bytecode][NFC] Clean up Integral::from() functions #169513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2025
+6 −11
Merged

[clang][bytecode][NFC] Clean up Integral::from() functions #169513

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d910829
[clang][bytecode][NFC] Clean up Integral::from() functions
tbaederr Nov 25, 2025
563d7c2
Merge branch 'main' into integral-from
tbaederr Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions clang/lib/AST/ByteCode/Integral.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,26 +202,21 @@ template <unsigned Bits, bool Signed> class Integral final {

static Integral min(unsigned NumBits) { return Integral(Min); }
static Integral max(unsigned NumBits) { return Integral(Max); }
static Integral zero(unsigned BitWidth = 0) { return from(0); }

template <typename ValT> static Integral from(ValT Value) {
if constexpr (std::is_integral<ValT>::value)
template <typename ValT>
static Integral from(ValT Value, unsigned NumBits = 0) {
if constexpr (std::is_integral_v<ValT>)
return Integral(Value);
else
return Integral::from(static_cast<Integral::ReprT>(Value));
return Integral(static_cast<Integral::ReprT>(Value));
}

template <unsigned SrcBits, bool SrcSign>
static std::enable_if_t<SrcBits != 0, Integral>
from(Integral<SrcBits, SrcSign> Value) {
static Integral from(Integral<SrcBits, SrcSign> Value) {
return Integral(Value.V);
}

static Integral zero(unsigned BitWidth = 0) { return from(0); }

template <typename T> static Integral from(T Value, unsigned NumBits) {
return Integral(Value);
}

static bool inRange(int64_t Value, unsigned NumBits) {
return CheckRange<ReprT, Min, Max>(Value);
}
Expand Down