From c4c24fd8c3b4373fe441e05fb19288917610839f Mon Sep 17 00:00:00 2001 From: Jack Styles Date: Tue, 2 Dec 2025 08:55:35 +0000 Subject: [PATCH 1/2] [mlir][OpenMP] Fix assert in processing of dist_schedule When #152736 was initially merged, the assert that checks for the chunksize when applying a static-chunked schedule was incorrect. While it would not have changed the behaviour of the assert, the string attached to it would have been emitted in cases where it was simplified. --- llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp index 6f73d0c8dbfa2..550e392b9228f 100644 --- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp +++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp @@ -5514,7 +5514,7 @@ OpenMPIRBuilder::InsertPointOrErrorTy OpenMPIRBuilder::applyWorkshareLoop( switch (EffectiveScheduleType & ~OMPScheduleType::ModifierMask) { case OMPScheduleType::BaseStatic: case OMPScheduleType::BaseDistribute: - assert(!ChunkSize || !DistScheduleChunkSize && + assert((!ChunkSize || !DistScheduleChunkSize) && "No chunk size with static-chunked schedule"); if (IsOrdered && !HasDistSchedule) return applyDynamicWorkshareLoop(DL, CLI, AllocaIP, EffectiveScheduleType, From 6b72bef32f00e639c2fcd060e5e47a4de97ca08b Mon Sep 17 00:00:00 2001 From: Jack Styles Date: Tue, 2 Dec 2025 09:54:53 +0000 Subject: [PATCH 2/2] formatting --- llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp index 550e392b9228f..553333d53a106 100644 --- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp +++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp @@ -5515,7 +5515,7 @@ OpenMPIRBuilder::InsertPointOrErrorTy OpenMPIRBuilder::applyWorkshareLoop( case OMPScheduleType::BaseStatic: case OMPScheduleType::BaseDistribute: assert((!ChunkSize || !DistScheduleChunkSize) && - "No chunk size with static-chunked schedule"); + "No chunk size with static-chunked schedule"); if (IsOrdered && !HasDistSchedule) return applyDynamicWorkshareLoop(DL, CLI, AllocaIP, EffectiveScheduleType, NeedsBarrier, ChunkSize);