-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Multi platofmr test fork #170554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Multi platofmr test fork #170554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that we can read from multiple files emitted by the premerge workflow. Pull Request: llvm#170411
Now that the issue-write workflow can support writing comments from multiple files, make the premerge workflow write out comments from both x86_64 Linux and Windows. AArch64 Linux right now is left out as the premerge advisor does not currently support it. Pull Request: llvm#170414
Member
|
@llvm/pr-subscribers-github-workflow @llvm/pr-subscribers-infrastructure Author: Aiden Grossman (boomanaiden154) ChangesFull diff: https://github.com/llvm/llvm-project/pull/170554.diff 4 Files Affected:
diff --git a/.ci/premerge_advisor_explain.py b/.ci/premerge_advisor_explain.py
index 155e91bef55f8..bd65eb3d1588b 100644
--- a/.ci/premerge_advisor_explain.py
+++ b/.ci/premerge_advisor_explain.py
@@ -129,7 +129,8 @@ def main(
# If the job succeeds and there is not an existing comment, we
# should not write one to reduce noise.
comments = []
- with open("comments", "w") as comment_file_handle:
+ comments_file_name = f"comments-{platform.system()}-{platform.machine()}"
+ with open(comments_file_name, "w") as comment_file_handle:
json.dump(comments, comment_file_handle)
diff --git a/.github/workflows/issue-write-test.yaml b/.github/workflows/issue-write-test.yaml
index 422a369fe0185..c976c9378e8f4 100644
--- a/.github/workflows/issue-write-test.yaml
+++ b/.github/workflows/issue-write-test.yaml
@@ -12,14 +12,20 @@ jobs:
test-issue-write:
name: "Test Issue Write"
runs-on: ubuntu-24.04
- if: github.repository == 'llvm/llvm-project'
steps:
- name: Write Comment
run: |
- echo '[{"body": "This is a comment for testing the issue write workflow"}]' > comments
+ echo '[{"body": "This is a comment for testing the issue write workflow"}]' > comments-foo
+ echo '[{"body": "This is another comment for testing the issue write workflow that was placed in a separate file"}]' > comments-bar
- name: Upload Comment
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
with:
- name: workflow-args
+ name: workflow-args-foo
path: |
- comments
+ comments-foo
+ - name: Upload Comment
+ uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
+ with:
+ name: workflow-args-bar
+ path: |
+ comments-bar
diff --git a/.github/workflows/issue-write.yml b/.github/workflows/issue-write.yml
index ac75dffd8b3b8..9ceadbe971093 100644
--- a/.github/workflows/issue-write.yml
+++ b/.github/workflows/issue-write.yml
@@ -47,7 +47,12 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
var fs = require('fs');
- const comments = JSON.parse(fs.readFileSync('./comments'));
+ var comments = []
+ for (local_file of fs.readdirSync('.')) {
+ if (local_file.startsWith("comments")) {
+ comments.push(...JSON.parse(fs.readFileSync(local_file)))
+ }
+ }
if (!comments || comments.length == 0) {
return;
}
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 10f7f6a827b30..4ea5397edbeac 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -124,9 +124,9 @@ jobs:
if: ${{ always() && !startsWith(matrix.runs-on, 'depot-ubuntu-24.04-arm') }}
continue-on-error: true
with:
- name: workflow-args
+ name: workflow-args-x86-linux
path: |
- comments
+ comments-Linux-x86_64
premerge-checks-windows:
name: Build and Test Windows
@@ -185,6 +185,14 @@ jobs:
path: artifacts/
retention-days: 5
include-hidden-files: 'true'
+ - name: Upload Comment
+ uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
+ if: always()
+ continue-on-error: true
+ with:
+ name: workflow-args-windows
+ path: |
+ comments-Windows-x86_64
premerge-check-macos:
name: MacOS Premerge Checks
|
Contributor
Author
|
Should've been opened against my fork for testing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.