Skip to content

Conversation

@lntue
Copy link
Contributor

@lntue lntue commented Jan 5, 2024

No description provided.

Copy link
Member

@nickdesaulniers nickdesaulniers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my fullbuild with clang, for each of the functions modified in this patch, I observe the following build errors:

/android0/llvm-project/libc/src/stdlib/bsearch.cpp:16:7: error: 'bsearch' is missing exception specification 'throw()'
   16 | void *bsearch(const void *key, const void *array, size_t array_size,
      |       ^
   17 |               size_t elem_size, int (*compare)(const void *, const void *)) {
      |                                                                             throw()
/android0/llvm-project/libc/src/stdlib/bsearch.h:18:26: note: previous declaration is here
   18 | LIBC_FUNCTION_DECL void *bsearch(const void *key, const void *array,
      |                          ^

#define LLVM_LIBC_FUNCTION_ATTR
#endif

#if defined(LIBC_COPT_PUBLIC_PACKAGING)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's only 1 expression, prefer ifdef over if defined.

@lntue lntue closed this Mar 23, 2025
@lntue lntue deleted the alias branch March 23, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants