Skip to content

[libc] pipe(2) linux syscall wrapper and unittest #85514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

[libc] pipe(2) linux syscall wrapper and unittest #85514

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6a75de8
pipe(2) linux syscall wrapper and unittest
muffpy Mar 16, 2024
a8afc5c
Format patch using git-clang-format
muffpy Mar 16, 2024
174676f
Fix typo in Pipe2BadFlags test
muffpy Mar 16, 2024
c6fab70
Set correct errors and test titles based on Linux standard
muffpy Mar 16, 2024
30d2385
Remove unwanted headers from pipe2_test and fix Pipe2InvalidFlags test
muffpy Mar 16, 2024
53c43e3
Pass unsupported flags to pipe(2) in Pipe2InvalidFlags test
muffpy Mar 16, 2024
6100033
Add fcntl.h to access file control flags for Pipe2InvalidFlags test
muffpy Mar 16, 2024
7b87696
Fix header ordering and pipe(2) failure convention
muffpy Mar 18, 2024
863c2ab
pipe(2) functionality and error handling tests + watch queue uapi macros
muffpy Mar 19, 2024
63d9955
Clang formatting
muffpy Mar 19, 2024
4cf1101
Fix pipe(2) function spec + remove fallback to pipe()
muffpy Mar 19, 2024
95f743d
Heading comment formatting + ArgSpec TODO
muffpy Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libc/src/unistd/linux/pipe2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@

#include "src/__support/OSUtil/syscall.h" // For internal syscall function.
#include "src/__support/common.h"

#include "src/errno/libc_errno.h"

#include <sys/syscall.h> // For syscall numbers.

namespace LIBC_NAMESPACE {
Expand All @@ -26,7 +26,7 @@ LLVM_LIBC_FUNCTION(int, pipe2, (int pipefd[2], int flags)) {
#else
#error "pipe and pipe2 not available."
#endif
if (ret == -1) {
if (ret < 0) {
libc_errno = -ret;
return -1;
}
Expand Down
2 changes: 0 additions & 2 deletions libc/src/unistd/pipe2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
#ifndef LLVM_LIBC_SRC_UNISTD_PIPE2_H
#define LLVM_LIBC_SRC_UNISTD_PIPE2_H

#include <unistd.h>

namespace LIBC_NAMESPACE {

int pipe2(int pipefd[2], int flags);
Expand Down
2 changes: 1 addition & 1 deletion libc/test/src/unistd/pipe2_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ TEST(LlvmLibcPipe2Test, ReadAndWriteViaPipe2) {
ASSERT_ERRNO_SUCCESS();
}

TEST(LlvmLibcPipe2Test, Pipe2InvalidFlags) {
TEST(LlvmLibcPipe2Test,Pipe2InvalidFlags) {
int invalidflags = O_CREAT | O_PATH | O_SYNC;
int pipefd[2];

Expand Down