Skip to content

[LLDB] Add more helper functions to ValueObject class. #87197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 13, 2024
Merged

[LLDB] Add more helper functions to ValueObject class. #87197

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
68cb68d
[LLDB] Add more helper functions to ValueObject class.
cmtice Mar 31, 2024
b6a1e23
Merge branch 'main' of github.com:llvm/llvm-project into dil-valobj-2
cmtice Apr 8, 2024
145e74b
[LLDB] Add more helper functions to ValueObject class.
cmtice Apr 8, 2024
22e1b06
[LLDB] Fix review comments for "CreateValueObjectFrom..." functions.
cmtice Apr 23, 2024
b8eee30
Merge remote-tracking branch 'origin/main' into dil-valobj-2
cmtice Apr 23, 2024
8709f70
Merge remote-tracking branch 'origin/main' into dil-valobj-2
cmtice May 19, 2024
1e41bfa
[LLDB] Add more helper functions to ValueObject class.
cmtice May 22, 2024
28748a9
[LLDB] Add more helper functions to ValueObject.
cmtice Jun 5, 2024
499a097
Fix comment.
cmtice Jun 6, 2024
fa25850
[LLDB] Add more helper functions to ValueObject class.
cmtice Jun 6, 2024
d4e7f69
[LLDB] Add more helper functions to ValueObject class.
cmtice Jun 6, 2024
6ca00e8
[LLDB] Add more helper functions to ValueObject class.
cmtice Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lldb/source/Core/ValueObject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3141,15 +3141,15 @@ lldb::ValueObjectSP ValueObject::CastToBasicType(CompilerType type) {
val_byte_size = temp.value();

if (is_pointer) {
if (!type.IsInteger()) {
m_error.SetErrorString("target type must be an integer");
return GetSP();
}
if (!type.IsBoolean() && type_byte_size < val_byte_size) {
Copy link
Collaborator

@jimingham jimingham Jun 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure what the original code intended with that type.IsBoolean? Makes no sense we would only return the "too small" error when the incoming type is Boolean.

But with this code, if I pass 32 bit float (on a 64 bit pointers system), the error I'll get is that it's too small. OTOH, if I pass a 64 bit float, I'll get "must be integer". That's confusing. If you aren't planning to take anything but integers, it seems like you should check that first, then check the size.

Copy link
Contributor Author

@cmtice cmtice Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@jimingham jimingham Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better, but now the type.IsBoolean is entirely pointless, since you would never get to this code in that case.

Copy link
Contributor Author

@cmtice cmtice Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Good catch; I've fixed that now.

m_error.SetErrorString(
"target type cannot be smaller than the pointer type");
return GetSP();
}
if (!type.IsInteger()) {
m_error.SetErrorString("target type must be an integer");
return GetSP();
}
}

if (type.IsBoolean()) {
Expand Down