Skip to content

[llvm] Add CalleeTypeIds field to CallSiteInfo #87574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 82 commits into from
Jul 23, 2025
Merged

[llvm] Add CalleeTypeIds field to CallSiteInfo #87574

merged 82 commits into from
Jul 23, 2025

Conversation

@Prabhuk
Copy link
Contributor

@Prabhuk Prabhuk commented Apr 3, 2024 •
edited
Loading

Introducing EnableCallGraphSection target option to add
CalleeTypeIds field in CallSiteInfo. Read the callee type ids
in and out by the MIR parser/printer.

@necipfazil @Prabhuk
[𝘀𝗽𝗿] changes to main this commit is based on
00ac51b 
Created using spr 1.3.6-beta.1

[skip ci]
@necipfazil @Prabhuk
[𝘀𝗽𝗿] initial version
0ca57bd 
Created using spr 1.3.6-beta.1
Prabhuk pushed a commit to Prabhuk/llvm-project that referenced this pull request Apr 19, 2024
@necipfazil @Prabhuk
[CallSiteInfo][CallGraphSection] Extend CallSiteInfo with TypeId
2b6eec5 
Add TypeId field to CallSiteInfo for tracking callee type id. Read the type
id in and out by the MIR parser/printer.

With this patch, TypeId is only set from callSites.typeId fields from MIR
inputs. An upcoming patch will pass type ids from the clang front-end,
and they will be read and set while lowering in the LLVM middle-end.

Original RFC: https://lists.llvm.org/pipermail/llvm-dev/2021-June/151044.html
Updated RFC: https://lists.llvm.org/pipermail/llvm-dev/2021-July/151739.html

Reviewed By:
morehouse

Differential Revision: https://reviews.llvm.org/D107110?id=362890

Pull Request: llvm#87574
Prabhuk and others added 14 commits April 24, 2024 11:16
@Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
21a4d2a 
Created using spr 1.3.6-beta.1

[skip ci]
@necipfazil @Prabhuk
Rebased on top of main
b9e7dc5 
Created using spr 1.3.6-beta.1
@Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
86ba0b1 
Created using spr 1.3.6-beta.1

[skip ci]
@necipfazil @Prabhuk
dyn_cast to isa
683d7c3 
Created using spr 1.3.6-beta.1
@Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
cd0cabe 
Created using spr 1.3.6-beta.1

[skip ci]
@necipfazil @Prabhuk
Addressed review comments except for the verifier check. Rebased on u…
661af56 
…pstream main.

Created using spr 1.3.6-beta.1
@necipfazil @Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
639a497 
Created using spr 1.3.6-beta.1

[skip ci]
@necipfazil @Prabhuk
Rebase patchset
ae8f56a 
Created using spr 1.3.6-beta.1
@necipfazil @Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
120cb54 
Created using spr 1.3.6-beta.1

[skip ci]
@necipfazil @Prabhuk
Update inline comment as suggested.
d573bf0 
Created using spr 1.3.6-beta.1
@necipfazil @Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
2cb9de4 
Created using spr 1.3.6-beta.1

[skip ci]
@necipfazil @Prabhuk
Rebase on top of upstream main.
26a149b 
Created using spr 1.3.6-beta.1
@Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
cf96ec2 
Created using spr 1.3.6-beta.1

[skip ci]
@necipfazil @Prabhuk
Break clang and llvm parts into separate commits.
807cb0a 
Created using spr 1.3.6-beta.1
@Prabhuk Prabhuk requested review from arsenm and ilovepi November 20, 2024 22:11
Prabhuk and others added 2 commits December 10, 2024 14:54
@Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
5455d3b 
Created using spr 1.3.6-beta.1

[skip ci]
@necipfazil @Prabhuk
Address review comments. Break llvm and clang patches.
3ab92c5 
Created using spr 1.3.6-beta.1
@Prabhuk Prabhuk changed the title [CallSiteInfo][CallGraphSection] Extend CallSiteInfo with TypeId [llvm] Extend CallSiteInfo with TypeId Dec 10, 2024
ilovepi
ilovepi reviewed Dec 11, 2024
View reviewed changes
arsenm
arsenm reviewed Dec 12, 2024
View reviewed changes
necipfazil and others added 3 commits February 2, 2025 00:58
@necipfazil @Prabhuk
Simplify MIR test.
1d7ee61 
Created using spr 1.3.6-beta.1
@Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
d235c0f 
Created using spr 1.3.6-beta.1

[skip ci]
@necipfazil @Prabhuk
Rebase on top of main.
1cf40e1 
Created using spr 1.3.6-beta.1
@Prabhuk Prabhuk mentioned this pull request Feb 2, 2025
Closed
Prabhuk and others added 2 commits February 5, 2025 23:07
@Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
9db0468 
Created using spr 1.3.6-beta.1

[skip ci]
@necipfazil @Prabhuk
Rename OB_type to OB_callee_type.
39017d7 
Created using spr 1.3.6-beta.1
Prabhuk and others added 9 commits July 18, 2025 15:33
@Prabhuk
Rebase on parent
154cede 
Created using spr 1.3.6-beta.1
@Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
cf8aeae 
Created using spr 1.3.6-beta.1

[skip ci]
@Prabhuk
Rebase on top of main.
b2d6cbc 
Created using spr 1.3.6-beta.1
@Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
58b5d3d 
Created using spr 1.3.6-beta.1

[skip ci]
@Prabhuk
Rebase on parent.
9456466 
Created using spr 1.3.6-beta.1
@Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
37d8b40 
Created using spr 1.3.6-beta.1

[skip ci]
@Prabhuk
Rebase on parent.
2d1d17f 
Created using spr 1.3.6-beta.1
@kkwli @Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
18b26b5 
Created using spr 1.3.6-beta.1

[skip ci]
@Prabhuk
Address review comments.
6928996 
Created using spr 1.3.6-beta.1
@Prabhuk Prabhuk changed the title [llvm] Add option to emit callgraph section [llvm] Add CalleeTypeIds field to CallSiteInfo Jul 18, 2025
@Prabhuk
Copy link
Contributor Author

Prabhuk commented Jul 18, 2025

I landed the patch that's a parent patch to this one #87573
@arsenm -- Can you please let me know if you have any concerns in landing this patch?

topperc and others added 4 commits July 21, 2025 21:44
@topperc @Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
09ba547 
Created using spr 1.3.6-beta.1

[skip ci]
@Prabhuk
Rebase on top of main.
3a41234 
Created using spr 1.3.6-beta.1
@RKSimon @Prabhuk
[𝘀𝗽𝗿] changes introduced through rebase
f5b15c6 
Created using spr 1.3.6-beta.1

[skip ci]
@Prabhuk
Rebase.
72b0dd0 
Created using spr 1.3.6-beta.1
@Prabhuk Prabhuk changed the base branch from users/Prabhuk/sprmain.callsiteinfocallgraphsection-extend-callsiteinfo-with-typeid to main July 22, 2025 18:00
@Prabhuk
Reduce tests. Rename function names in tests.
79920a8 
Created using spr 1.3.6-beta.1
@ilovepi
Copy link
Contributor

ilovepi commented Jul 23, 2025

LGTM w/ the improved/reduced tests.

@Prabhuk Prabhuk merged commit 7baf4bd into main Jul 23, 2025
9 checks passed
@Prabhuk Prabhuk deleted the users/Prabhuk/sprcallsiteinfocallgraphsection-extend-callsiteinfo-with-typeid branch July 23, 2025 17:11
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Jul 23, 2025
@Prabhuk @github-actions
Automerge: [llvm] Add CalleeTypeIds field to CallSiteInfo
97afbcb 
Introducing `EnableCallGraphSection` target option to add
CalleeTypeIds field in CallSiteInfo. Read the callee type ids
in and out by the MIR parser/printer.

Reviewers: ilovepi

Reviewed By: ilovepi

Pull Request: llvm/llvm-project#87574
@vvereschaka
Copy link
Contributor

vvereschaka commented Jul 23, 2025 •
edited
Loading

@Prabhuk ,

there are many failed tests

FAIL: LLVM::call-site-info-direct-calls-typeid.mir
FAIL: LLVM::call-site-info-ambiguous-indirect-call-typeid.mir
FAIL: LLVM::call-site-info-typeid.mir

error: /home/buildbot/worker/as-builder-7/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/test/CodeGen/MIR/X86/call-site-info-typeid.mir:27:5: unknown machine instruction name 'CALL64m'
    CALL64m $noreg, 1, $noreg, 0, $noreg, csr_64, implicit $rsp, implicit $ssp, implicit $edi, implicit-def $rsp, implicit-def $ssp :: (load (s64) from `ptr null`)

on these builders:

https://lab.llvm.org/buildbot/#/builders/155/builds/11277
https://lab.llvm.org/buildbot/#/builders/180/builds/21832
https://lab.llvm.org/buildbot/#/builders/54/builds/11130
https://lab.llvm.org/buildbot/#/builders/160/builds/21689

would you take care of it?

@zeroomega zeroomega mentioned this pull request Jul 23, 2025
Merged
zeroomega added a commit that referenced this pull request Jul 23, 2025
@zeroomega
Revert "[llvm] Add CalleeTypeIds field to CallSiteInfo" (#150335)
05e08cd 
Reverts #87574, which breaks LLVM ::
CodeGen/MIR/X86/call-site-info-ambiguous-indirect-call-typeid.mir tests
on linux-arm64 builders.
@Prabhuk
Copy link
Contributor Author

Prabhuk commented Jul 23, 2025

Thanks @vvereschaka for reporting. And thanks @zeroomega for the revert.

llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Jul 23, 2025
@zeroomega @github-actions
Automerge: Revert "[llvm] Add CalleeTypeIds field to CallSiteInfo" (#…
ae71cb0 
…150335)

Reverts llvm/llvm-project#87574, which breaks LLVM ::
CodeGen/MIR/X86/call-site-info-ambiguous-indirect-call-typeid.mir tests
on linux-arm64 builders.
MarkMurrayARM pushed a commit to MarkMurrayARM/arm-toolchain that referenced this pull request Jul 24, 2025
@Prabhuk @MarkMurrayARM
[llvm] Add CalleeTypeIds field to CallSiteInfo
272a900 
Introducing `EnableCallGraphSection` target option to add
CalleeTypeIds field in CallSiteInfo. Read the callee type ids
in and out by the MIR parser/printer.

Reviewers: ilovepi

Reviewed By: ilovepi

Pull Request: llvm/llvm-project#87574
MarkMurrayARM pushed a commit to MarkMurrayARM/arm-toolchain that referenced this pull request Jul 24, 2025
@zeroomega @MarkMurrayARM
Revert "[llvm] Add CalleeTypeIds field to CallSiteInfo" (#150335)
b15f4c5 
Reverts llvm/llvm-project#87574, which breaks LLVM ::
CodeGen/MIR/X86/call-site-info-ambiguous-indirect-call-typeid.mir tests
on linux-arm64 builders.
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Jul 28, 2025
@Prabhuk @mahesh-attarde
[llvm] Add CalleeTypeIds field to CallSiteInfo
4b72e25 
Introducing `EnableCallGraphSection` target option to add
CalleeTypeIds field in CallSiteInfo. Read the callee type ids
in and out by the MIR parser/printer.

Reviewers: ilovepi

Reviewed By: ilovepi

Pull Request: llvm#87574
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Jul 28, 2025
@zeroomega @mahesh-attarde
Revert "[llvm] Add CalleeTypeIds field to CallSiteInfo" (llvm#150335)
2907dfe 
Reverts llvm#87574, which breaks LLVM ::
CodeGen/MIR/X86/call-site-info-ambiguous-indirect-call-typeid.mir tests
on linux-arm64 builders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arsenm arsenm arsenm left review comments

@ilovepi ilovepi ilovepi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Prabhuk @ilovepi @vvereschaka @arsenm @necipfazil @kkwli @topperc @RKSimon