Skip to content

Commit 3509bfa

Browse files
committed
[test-suite] Signal error if llvm-lit was not found
Summary: I'm not sure if that was intentional or not? I found it quite surprising when trying to integrate a new external project. Reviewers: MatzeB, homerdin, hfinkel Reviewed By: hfinkel Subscribers: mgorny, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D60091 llvm-svn: 364388
1 parent 002d73c commit 3509bfa

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

CMakeLists.txt

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ if(TEST_SUITE_COLLECT_CODE_SIZE)
9090
mark_as_advanced(TEST_SUITE_LLVM_SIZE)
9191
if(TEST_SUITE_LLVM_SIZE STREQUAL "TEST_SUITE_LLVM_SIZE-NOTFOUND")
9292
message(FATAL_ERROR "llvm-size not found.
93-
Make sure it is in your path or set TEST_SUITE_COLLECT_CODE_SIZE to OFF")
93+
Make sure it is in your path or specify it via -DTEST_SUITE_LLVM_SIZE:FILEPATH=\"\" or set TEST_SUITE_COLLECT_CODE_SIZE to OFF")
9494
endif()
9595
endif()
9696

@@ -107,7 +107,7 @@ if(TEST_SUITE_PROFILE_GENERATE)
107107
mark_as_advanced(TEST_SUITE_LLVM_PROFDATA)
108108
if(TEST_SUITE_LLVM_PROFDATA STREQUAL "TEST_SUITE_LLVM_PROFDATA-NOTFOUND")
109109
message(FATAL_ERROR "llvm-profdata not found.
110-
Make sure it is in your path or set TEST_SUITE_PROFILE_GENERATE to OFF")
110+
Make sure it is in your path or specify it via -DTEST_SUITE_LLVM_PROFDATA:FILEPATH=\"\" or set TEST_SUITE_PROFILE_GENERATE to OFF")
111111
endif()
112112

113113
set(TEST_SUITE_PROFILE_GENERATE "True")
@@ -216,7 +216,10 @@ endif()
216216
find_program(TEST_SUITE_LIT NAMES "lit" "llvm-lit")
217217
set(TEST_SUITE_LIT_FLAGS "-sv" CACHE STRING "Flags used when running lit")
218218
mark_as_advanced(TEST_SUITE_LIT TEST_SUITE_LIT_FLAGS)
219-
mark_as_advanced(TEST_SUITE_LIT)
219+
if(TEST_SUITE_LIT STREQUAL "TEST_SUITE_LIT-NOTFOUND")
220+
message(FATAL_ERROR "llvm-lit not found.
221+
Make sure it is in your path or specify it via -DTEST_SUITE_LIT:FILEPATH=\"\"")
222+
endif()
220223

221224
add_subdirectory(tools)
222225
# Shortcut for the path to the fpcmp executable

0 commit comments

Comments
 (0)