Skip to content

Commit a0e5ec8

Browse files
committed
utils/tdiff.py: Don't parse duplicate targets
When diffing a large target like all, most of the entries in the target list in query_ninja are duplicated. I haven't looked that closely as to why this is the case, but uniquing the list brought the size of it down from 21781 to 76 for me. Reviewed By: MatzeB Differential Revision: https://reviews.llvm.org/D156334
1 parent 745f3fd commit a0e5ec8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

utils/tdiff.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def parse(text):
8181
def query_ninja(targets, cwd):
8282
# Query ninja for a node in its build dependency tree.
8383
proc = subprocess.Popen(
84-
["ninja", "-t", "query"] + targets,
84+
["ninja", "-t", "query", *set(targets)],
8585
cwd=cwd,
8686
stdout=subprocess.PIPE,
8787
universal_newlines=True,

0 commit comments

Comments
 (0)