[flang] Disable two xfail tests that will soon not fail #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunprabhu
requested changes
Oct 11, 2024
Contributor
tarunprabhu
left a comment
tarunprabhu
left a comment
There was a problem hiding this comment.
The tests.cmake file is auto-generated and must not be edited by hand because it will be overwritten the next time the test suite is sync'ed with the upstream tests.
I am working on a way to override the DejaGNU annotations so that we can use such tests where the behavior of gfortran and flang are different. But for now, they would have to be disabled. If you could disable them and leave a comment indicating that they should not be xfail, I can re-enable them when the overriding mechanism is in place.
Thanks.
An upcoming PR to flang (llvm/llvm-project#112024) will soon allow two gfortran tests to compile and run successfully, which will come as a fatal surprise because they're marked "xfail".
Contributor
Author
|
Updated. |
klausler
changed the title
tarunprabhu
approved these changes
Oct 11, 2024
Contributor
tarunprabhu
left a comment
tarunprabhu
left a comment
There was a problem hiding this comment.
Thanks for making the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upcoming PR to flang (llvm/llvm-project#112024) will soon allow two gfortran tests to compile and run successfully, which will come as a fatal surprise because they're marked "xfail".