From 9c62825f22edcc7acd77ba0ba2a5d46548700a26 Mon Sep 17 00:00:00 2001 From: Asher Mancinelli Date: Mon, 28 Apr 2025 14:32:11 -0700 Subject: [PATCH 1/2] [Fortran] Disable gfortran volatile8 test This test expects the compiler to give a compilation error. Current LLVM flang does emit an error, but it's a TODO message because volatile variables are not handled yet. There are upcoming PRs to enable this though, and the front end ought to emit some diagnostic about this. Eugene E and Peter K are discussing whether these should be warnings or errors. While this is being discussed, disable the test so work on volatile can proceed. llvm-project#137369 --- Fortran/gfortran/regression/DisabledFiles.cmake | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Fortran/gfortran/regression/DisabledFiles.cmake b/Fortran/gfortran/regression/DisabledFiles.cmake index a2636bbe94..26735f6eb1 100644 --- a/Fortran/gfortran/regression/DisabledFiles.cmake +++ b/Fortran/gfortran/regression/DisabledFiles.cmake @@ -1053,6 +1053,8 @@ file(GLOB FAILING_FILES CONFIGURE_DEPENDS binding_label_tests_26b.f90 test_common_binding_labels_2_main.f03 string_1.f90 # Expect error on 32 bits platform + volatile8.f90 # Expects error on bad dummy argument declarations + # llvm-project#137369 # Tests that exercise gfortran's ability to set -std=f95 and then see errors on newer features abstract_type_1.f90 From 867aef5fc19e650b1d405fb0d4ee2d4bb5ddc174 Mon Sep 17 00:00:00 2001 From: Asher Mancinelli Date: Mon, 28 Apr 2025 17:16:52 -0700 Subject: [PATCH 2/2] More detailed comment --- Fortran/gfortran/regression/DisabledFiles.cmake | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Fortran/gfortran/regression/DisabledFiles.cmake b/Fortran/gfortran/regression/DisabledFiles.cmake index 26735f6eb1..4e9fcaa698 100644 --- a/Fortran/gfortran/regression/DisabledFiles.cmake +++ b/Fortran/gfortran/regression/DisabledFiles.cmake @@ -1053,7 +1053,10 @@ file(GLOB FAILING_FILES CONFIGURE_DEPENDS binding_label_tests_26b.f90 test_common_binding_labels_2_main.f03 string_1.f90 # Expect error on 32 bits platform - volatile8.f90 # Expects error on bad dummy argument declarations + volatile8.f90 # Gfortran expects compilation errors for invalid uses of volatile; flang + # supports one of these as an extension, and the others ought to either be warnings + # or errors. See the flang extensions document: "A non-definable actual argument, + # including the case of a vector subscript, may be associated with an ASYNCHRONOUS or VOLATILE dummy argument" # llvm-project#137369 # Tests that exercise gfortran's ability to set -std=f95 and then see errors on newer features