[BOLT] Excluding GNU build-id and cleanup. (#465)

Pass '--build-id' to the linker to disable emission of a unique build ID
into a note section. This breaks nfc-mode tests.

Additional cleanup:
- Out-of-tree tests are now labeled as 'BOLT large tests'
- Dropped step 'nfc-stat-check' as it was disabled
- Removed unused flags for Non-NFC tests

Author: paschalis-mpeis

buildbot/osuosl/master/config/builders.py

@@ -2997,6 +2997,7 @@
                     depends_on_projects=['bolt', 'llvm'],
                     extra_configure_args=[
                         "-DLLVM_APPEND_VC_REV=OFF",
+                        "-DCMAKE_EXE_LINKER_FLAGS='-Wl,--build-id=none'"
                         "-DCMAKE_C_COMPILER_LAUNCHER=ccache",
                         "-DCMAKE_CXX_COMPILER_LAUNCHER=ccache",
                         "-DLLVM_ENABLE_PROJECTS=clang;lld;bolt",

zorg/buildbot/builders/BOLTBuilder.py

@@ -44,16 +44,16 @@ def getBOLTCmakeBuildFactory(
             ]
         # Clean checkout of bolt-tests if cleanBuildRequested
         f.addSteps([
-            steps.RemoveDirectory(name="BOLT tests: clean",
+            steps.RemoveDirectory(name="BOLT large tests: clean",
                 dir=bolttests_dir,
                 haltOnFailure=True,
                 warnOnFailure=True,
                 doStepIf=cleanBuildRequestedByProperty),
 
-            steps.Git(name="BOLT tests: checkout",
+            steps.Git(name="BOLT large tests: checkout",
                 description="fetching",
                 descriptionDone="fetch",
-                descriptionSuffix="BOLT Tests",
+                descriptionSuffix="BOLT Large Tests",
                 repourl='https://github.com/rafaelauler/bolt-tests.git',
                 workdir=bolttests_dir,
                 alwaysUseLatest=True),
@@ -147,17 +147,6 @@ def getBOLTCmakeBuildFactory(
                 flunkOnFailure=False,
                 doStepIf=FileExists('build/.llvm-bolt.diff'),
                 env=env),
-            LitTestCommand(
-                name='nfc-stat-check',
-                command=(f"../{f.monorepo_dir}/bolt/utils/nfc-stat-parser.py "
-                         "`find -name timing.log`"),
-                description="Check BOLT processing time and max RSS swings",
-                warnOnFailure=True,
-                haltOnFailure=False,
-                flunkOnFailure=False,
-                #doStepIf=FileExists('build/.llvm-bolt.diff'),
-                doStepIf=False,
-                env=env),
             ])
 
     return f

zorg/buildbot/builders/UnifiedTreeBuilder.py

@@ -233,17 +233,18 @@ def trunc50(name):
     else:
         check_env = env or {}
 
-    for check in checks:
-        f.addStep(LitTestCommand(name=trunc50("test-%s-%s" % (step_name, check)),
-                                 command=['ninja', check],
-                                 description=[
-                                   "Test", "just", "built", "components", "for",
-                                   check,
-                                 ],
-                                 env=check_env,
-                                 workdir=obj_dir,
-                                 **kwargs # Pass through all the extra arguments.
-                                 ))
+    if checks:
+        for check in checks:
+            f.addStep(LitTestCommand(name=trunc50("test-%s-%s" % (step_name, check)),
+                                    command=['ninja', check],
+                                    description=[
+                                    "Test", "just", "built", "components", "for",
+                                    check,
+                                    ],
+                                    env=check_env,
+                                    workdir=obj_dir,
+                                    **kwargs # Pass through all the extra arguments.
+                                    ))
 
     # Install just built components
     if install_dir: