Skip to content

Commit a407fc0

Browse files
[CI] Add extra metadata to windows node pool
This patch adds additional metadata to the windows node pool so that running terraform apply does not force recreation of the node pool everytime, which is reasonably expensive time wise.
1 parent aa15ef9 commit a407fc0

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

premerge/main.tf

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,12 @@ resource "google_container_node_pool" "llvm_premerge_windows" {
118118
# Windows Defender causes an increase in test times by approximately an
119119
# order of magnitude.
120120
metadata = {
121-
"sysprep-specialize-script-ps1" : "Set-MpPreference -DisableRealtimeMonitoring $true"
121+
"sysprep-specialize-script-ps1" = "Set-MpPreference -DisableRealtimeMonitoring $true"
122+
# Terraform wants to recreate the node pool everytime whe running
123+
# terraform apply unless we explicitly set this.
124+
# TODO(boomanaiden154): Look into why terraform is doing this so we do
125+
# not need this hack.
126+
"disable-legacy-endpoints" = "true"
122127
}
123128
disk_size_gb = 200
124129
}

0 commit comments

Comments
 (0)