[sanitizers] Consolidate a shell variables initialization

Author: vitalybuka

zorg/buildbot/builders/sanitizers/buildbot_functions.sh

@@ -277,37 +277,35 @@ function build_stage2 {
   mkdir -p "${SANITIZER_LOG_DIR}"
 
   local log_path="${SANITIZER_LOG_DIR}/report"
+  local san_options="log_path=${log_path}:log_exe_name=1:abort_on_error=1"
 
   if [ "$sanitizer_name" == "msan" ]; then
     export MSAN_SYMBOLIZER_PATH="${llvm_symbolizer_path}"
-    export MSAN_OPTIONS="abort_on_error=1"
-    export MSAN_OPTIONS+=":log_path=${log_path}:log_exe_name=1"
+    export MSAN_OPTIONS="${san_options}"
     llvm_use_sanitizer="Memory"
     fsanitize_flag="-fsanitize=memory"
   elif [ "$sanitizer_name" == "msan_track_origins" ]; then
     export MSAN_SYMBOLIZER_PATH="${llvm_symbolizer_path}"
-    export MSAN_OPTIONS="abort_on_error=1"
-    export MSAN_OPTIONS+=":log_path=${log_path}:log_exe_name=1"
+    export MSAN_OPTIONS="${san_options}"
     llvm_use_sanitizer="MemoryWithOrigins"
     fsanitize_flag="-fsanitize=memory -fsanitize-memory-track-origins"
   elif [ "$sanitizer_name" == "asan" ]; then
     export ASAN_SYMBOLIZER_PATH="${llvm_symbolizer_path}"
     # TODO strict_init_order=true
     export ASAN_OPTIONS="check_initialization_order=true"
-    export ASAN_OPTIONS+=":log_path=${log_path}:log_exe_name=1"
+    export ASAN_OPTIONS+=":${san_options}:abort_on_error=0"
     llvm_use_sanitizer="Address"
     fsanitize_flag="-fsanitize=address"
   elif [ "$sanitizer_name" == "hwasan" ]; then
     export HWASAN_SYMBOLIZER_PATH="${llvm_symbolizer_path}"
-    export HWASAN_OPTIONS="abort_on_error=1"
-    export HWASAN_OPTIONS+=":log_path=${log_path}:log_exe_name=1"
+    export HWASAN_OPTIONS="${san_options}"
     llvm_use_sanitizer="HWAddress"
     fsanitize_flag="-fsanitize=hwaddress"
     # FIXME: Support globals with DSO https://github.com/llvm/llvm-project/issues/57206
     cmake_stage2_common_options+=" -DLLVM_ENABLE_PLUGINS=OFF"
   elif [ "$sanitizer_name" == "ubsan" ]; then
     export UBSAN_OPTIONS="external_symbolizer_path=${llvm_symbolizer_path}:print_stacktrace=1"
-    export UBSAN_OPTIONS+=":log_path=${log_path}:log_exe_name=1"
+    export UBSAN_OPTIONS+=":${san_options}:abort_on_error=0"
     llvm_use_sanitizer="Undefined"
     fsanitize_flag="-fsanitize=undefined -fno-sanitize-recover=all"
     # FIXME: After switching to LLVM_ENABLE_RUNTIMES, vptr has infitine
@@ -317,7 +315,7 @@ function build_stage2 {
     # TODO strict_init_order=true
     export ASAN_SYMBOLIZER_PATH="${llvm_symbolizer_path}"
     export ASAN_OPTIONS="check_initialization_order=true"
-    export ASAN_OPTIONS+=":log_path=${log_path}:log_exe_name=1"
+    export ASAN_OPTIONS+=":${san_options}:abort_on_error=0"
     export UBSAN_OPTIONS="print_stacktrace=1"
     llvm_use_sanitizer="Address;Undefined"
     fsanitize_flag="-fsanitize=address,undefined -fno-sanitize-recover=all"