Commit bb44c37
authored
Linaro / Windows: Use LLVM_CCACHE_BUILD instead of CMAKE_CXX_COMPILER_LAUNCHER (#464)
There's nothing wrong with the latter - except that LLVM_CCACHE_BUILD
knows that it should not be enabling pre-compiled headers on Windows.
See llvm/llvm-project#136856
We had a contributor report an issue with this, and it only got fixed
when someone randomly managed to update the right files for an unrelated
change.
```
/Fdtools\flang\lib\Parser\CMakeFiles\FortranParser.dir\FortranParser.pdb
-c -- C:/Users/tcwg/llvm-worker/flang-arm64-windows-msvc/llvm-project/flang/lib/Parser/preprocessor.cpp
fatal error: file
'C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\llvm\include\llvm\Support\Compiler.h'
has been modified since the precompiled header
'C:/Users/tcwg/llvm-worker/flang-arm64-windows-msvc/build/tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/./cmake_pch.cxx.pch'
was built: size changed (was 26948, now 27102)
note: please rebuild precompiled header
'C:/Users/tcwg/llvm-worker/flang-arm64-windows-msvc/build/tools/flang/lib/Parser/CMakeFiles/FortranParser.dir/./cmake_pch.cxx.pch'
1 error generated.
```
This sounds like a known issue, and if we use LLVM_CCACHE_BUILD,
precompiled headers will be disabled. This is fine, our bots weren't
relying on this anyway.
As far as I could tell we don't customise the ccache install at all
either, so the defaults are all fine for us.
I've applied this to all 4 Windows bots:
clang-arm64-windows-msvc
clang-arm64-windows-msvc-2stage
flang-arm64-windows-msvc
lldb-aarch64-windows
The problem is with flang specifically, but we might as well standardise
across them all.1 parent ba51397 commit bb44c37
1 file changed
+4
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
331 | 331 | | |
332 | 332 | | |
333 | 333 | | |
334 | | - | |
335 | | - | |
| 334 | + | |
336 | 335 | | |
337 | 336 | | |
338 | 337 | | |
| |||
665 | 664 | | |
666 | 665 | | |
667 | 666 | | |
668 | | - | |
669 | | - | |
| 667 | + | |
670 | 668 | | |
671 | 669 | | |
672 | 670 | | |
| |||
1448 | 1446 | | |
1449 | 1447 | | |
1450 | 1448 | | |
1451 | | - | |
1452 | | - | |
| 1449 | + | |
1453 | 1450 | | |
1454 | 1451 | | |
1455 | 1452 | | |
| |||
2656 | 2653 | | |
2657 | 2654 | | |
2658 | 2655 | | |
2659 | | - | |
2660 | | - | |
| 2656 | + | |
2661 | 2657 | | |
2662 | 2658 | | |
2663 | 2659 | | |
| |||
0 commit comments