Skip to content

Commit 0ad46db

Browse files
committed
Set bindings for VK descriptors to match pipeline
This gets this testcase working under Vulkan.
1 parent ac1c68d commit 0ad46db

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/Basic/DescriptorSets.test

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
#define REGISTER(Idx, Space) : register(Idx, Space)
77
#endif
88

9-
RWBuffer<float4> In REGISTER(u0, space0);
10-
RWBuffer<float4> Out1 REGISTER(u1, space4);
11-
RWBuffer<float4> Out2 REGISTER(u2, space4);
9+
[[vk::binding(0)]] RWBuffer<float4> In REGISTER(u0, space0);
10+
[[vk::binding(1)]] RWBuffer<float4> Out1 REGISTER(u1, space4);
11+
[[vk::binding(0,1)]] RWBuffer<float4> Out2 REGISTER(u2, space4);
1212

1313
[numthreads(1,1,1)]
1414
void main(uint GI : SV_GroupIndex) {
@@ -45,12 +45,12 @@ DescriptorSets:
4545
...
4646
#--- end
4747

48+
# UNSUPPORTED: Clang
4849
# RUN: split-file %s %t
4950
# RUN: %if DirectX %{ dxc -T cs_6_0 -Fo %t.dxil %t/DescriptorSets.hlsl %}
5051
# RUN: %if DirectX %{ %offloader %t/DescriptorSets.yaml %t.dxil | FileCheck %s %}
5152
# RUN: %if Vulkan %{ dxc -T cs_6_0 -spirv -fspv-target-env=vulkan1.1 -Fo %t.spv %t/DescriptorSets.hlsl %}
5253
# RUN: %if Vulkan %{ %offloader %t/DescriptorSets.yaml %t.spv | FileCheck %s %}
53-
# XFAIL: Vulkan-NV
5454

5555
# RUN: %if Metal %{ dxc -T cs_6_0 -Fo %t.dxil %t/DescriptorSets.hlsl %}
5656
# RUN: %if Metal %{ metal-shaderconverter %t.dxil -o=%t.metallib %}

0 commit comments

Comments
 (0)