Skip to content

Commit 24b2efb

Browse files
authored
Enable most of the cbuffer tests for clang (#280)
These have been working for some time but we never enabled the tests.
1 parent 9825eb1 commit 24b2efb

File tree

5 files changed

+14
-2
lines changed

5 files changed

+14
-2
lines changed

test/Feature/CBuffer/arrays-16bit.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ DescriptorSets:
5959
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
6060
# UNSUPPORTED: Vulkan
6161

62-
# https://github.com/llvm/llvm-project/issues/110722
62+
# https://github.com/llvm/llvm-project/issues/138996
6363
# XFAIL: Clang
6464

6565
# RUN: split-file %s %t

test/Feature/CBuffer/lit.local.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
if 'Clang' in config.available_features:
1+
if 'Clang-Vulkan' in config.available_features:
22
config.unsupported = True
33

44
# CBuffer bindings seem to be broken under metal

test/Feature/CBuffer/structs.test

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,10 @@ DescriptorSets:
9797
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
9898
# UNSUPPORTED: Vulkan
9999

100+
+# Clang trips on 2-element vectors in structs:
101+
+# https://github.com/llvm/llvm-project/issues/123968
102+
+# XFAIL: Clang
103+
100104
# RUN: split-file %s %t
101105
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
102106
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s

test/Feature/CBuffer/vectors-64bit.test

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ DescriptorSets:
6363
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
6464
# UNSUPPORTED: Vulkan
6565

66+
# Clang trips on 3-element vectors in structs:
67+
# https://github.com/llvm/llvm-project/issues/123968
68+
# XFAIL: Clang
69+
6670
# RUN: split-file %s %t
6771
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
6872
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s

test/Feature/CBuffer/vectors.test

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ DescriptorSets:
6363
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
6464
# UNSUPPORTED: Vulkan
6565

66+
# Clang trips on 3-element vectors in structs:
67+
# https://github.com/llvm/llvm-project/issues/123968
68+
# XFAIL: Clang
69+
6670
# RUN: split-file %s %t
6771
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
6872
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s

0 commit comments

Comments
 (0)