Skip to content

Commit 550c29c

Browse files
authored
Update tests to follow new Bug/Unimplemented convention + clean up some tests (#394)
Removes XFAILS from tests if the linked issue was closed. Added new XFAILS when appropriate. Put Bug or Unimplemented next to linked Issue when appropriate fix up log.16 test to not use inf/nan/denorm inputs A few other minor changes Closes #381
1 parent f528875 commit 550c29c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

73 files changed

+135
-133
lines changed

README.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,16 @@ The offload test suite's code is clang-tidy clean for a limited ruleset.
5555
If you have clang-tidy installed locally you can enable clang-tidy by adding `-DOFFLOADTEST_USE_CLANG_TIDY=On` to your CMake invocation.
5656
You can also add `-DOFFLOADTEST_CLANG_TIDY_APPLY_FIX=On` to enable automatically applying the clang-tidy fix-its for any warnings that have automated fixes.
5757

58+
# Failing tests
59+
60+
Tests which are failing can be prevented from running using `XFAIL` and `UNSUPPORTED`. When `XFAIL`ing a test make sure to add a comment above
61+
linking the appropriate issue and whether the failure is due to a bug or an unimplemented feature.
62+
63+
```
64+
# Bug/Unimplemented <link to issue>
65+
# XFAIL: Clang-Vulkan
66+
```
67+
5868
# YAML Pipeline Format
5969

6070
This framework provides a YAML representation for describing GPU pipelines and buffers. The format is implemented by the `API/Pipeline.{h|cpp}` sources. The following is an example pipeline YAML description:

test/Bugs/Adjacent-Partial-Writes.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ DescriptorSets:
6262
# UHD drivers. This issue does not reproduce when compiled with Clang because
6363
# LLVM's load-store optimization performs correct optimizations that hide the
6464
# problem.
65-
# Tracking issue: https://github.com/llvm/offload-test-suite/issues/226
65+
# Bug https://github.com/llvm/offload-test-suite/issues/226
6666
# XFAIL: Intel-Memory-Coherence-Issue-226 && !Clang
6767

6868
# https://github.com/microsoft/DirectXShaderCompiler/issues/7494

test/Bugs/UAV-Sequental-Consistency.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ DescriptorSets:
6262
# problem.
6363
# This test fails randomly but inconsistently without validation enabled. With
6464
# validation enabled it fails consistently every time.
65-
# Tracking issue: https://github.com/llvm/offload-test-suite/issues/226
65+
# Bug https://github.com/llvm/offload-test-suite/issues/226
6666
# XFAIL: Intel-Memory-Coherence-Issue-226 && !Clang
6767

6868
# RUN: split-file %s %t

test/Feature/CBuffer/arrays-16bit.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ DescriptorSets:
5959
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
6060
# UNSUPPORTED: Vulkan
6161

62-
# https://github.com/llvm/llvm-project/issues/138996
62+
# Bug https://github.com/llvm/llvm-project/issues/138996
6363
# XFAIL: Clang
6464

6565
# RUN: split-file %s %t

test/Feature/CBuffer/arrays-64bit.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ DescriptorSets:
6363
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
6464
# UNSUPPORTED: Vulkan
6565

66-
# https://github.com/llvm/llvm-project/issues/110722
66+
# Unimplemented https://github.com/llvm/llvm-project/issues/147352
6767
# XFAIL: Clang
6868

6969
# REQUIRES: Double, Int64

test/Feature/CBuffer/arrays.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ DescriptorSets:
6363
# DXC's vulkan support does not layout cbuffers compatibly with DXIL
6464
# UNSUPPORTED: Vulkan
6565

66-
# https://github.com/llvm/llvm-project/issues/110722
66+
# Unimplemented https://github.com/llvm/llvm-project/issues/147352
6767
# XFAIL: Clang
6868

6969
# RUN: split-file %s %t

test/Feature/CBuffer/structs.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ DescriptorSets:
9898
# UNSUPPORTED: Vulkan
9999

100100
+# Clang trips on 2-element vectors in structs:
101-
+# https://github.com/llvm/llvm-project/issues/123968
101+
+# Bug https://github.com/llvm/llvm-project/issues/123968
102102
+# XFAIL: Clang
103103

104104
# RUN: split-file %s %t

test/Feature/CBuffer/vectors-64bit.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ DescriptorSets:
6464
# UNSUPPORTED: Vulkan
6565

6666
# Clang trips on 3-element vectors in structs:
67-
# https://github.com/llvm/llvm-project/issues/123968
67+
# Bug https://github.com/llvm/llvm-project/issues/123968
6868
# XFAIL: Clang
6969

7070
# RUN: split-file %s %t

test/Feature/CBuffer/vectors.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ DescriptorSets:
6464
# UNSUPPORTED: Vulkan
6565

6666
# Clang trips on 3-element vectors in structs:
67-
# https://github.com/llvm/llvm-project/issues/123968
67+
# Bug https://github.com/llvm/llvm-project/issues/123968
6868
# XFAIL: Clang
6969

7070
# RUN: split-file %s %t

test/Feature/HLSLLib/D3DCOLORtoUBYTE4.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ DescriptorSets:
5151
#--- end
5252

5353

54-
# https://github.com/llvm/llvm-project/issues/149561
54+
# Bug https://github.com/llvm/llvm-project/issues/149561
5555
# XFAIL: Clang-Vulkan && !VK_KHR_shader_float_controls2
5656

5757
# RUN: split-file %s %t

0 commit comments

Comments
 (0)