Skip to content

Commit 6863e57

Browse files
authored
Remove XFAILs for unsigned abs and update the issue for unsigned sign (#439)
Update tests now that microsoft/DirectXShaderCompiler#7512 is resolved, but note that the `sign` failures were incorrectly attributed to that issue.
1 parent 4a24963 commit 6863e57

File tree

6 files changed

+3
-12
lines changed

6 files changed

+3
-12
lines changed

test/Feature/HLSLLib/abs.32.test

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,6 @@ DescriptorSets:
134134
...
135135
#--- end
136136

137-
# Bug https://github.com/microsoft/DirectXShaderCompiler/issues/7512
138-
# XFAIL: DXC-Vulkan
139-
140137
# RUN: split-file %s %t
141138
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl
142139
# RUN: %offloader %t/pipeline.yaml %t.o

test/Feature/HLSLLib/abs.int16.test

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,6 @@ DescriptorSets:
9494
...
9595
#--- end
9696

97-
# Bug https://github.com/microsoft/DirectXShaderCompiler/issues/7512
98-
# XFAIL: DXC-Vulkan
99-
10097
# REQUIRES: Int16
10198
# RUN: split-file %s %t
10299
# RUN: %dxc_target -enable-16bit-types -T cs_6_5 -Fo %t.o %t/source.hlsl

test/Feature/HLSLLib/abs.int64.test

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,6 @@ DescriptorSets:
9494
...
9595
#--- end
9696

97-
# Bug https://github.com/microsoft/DirectXShaderCompiler/issues/7512
98-
# XFAIL: DXC-Vulkan
99-
10097
# REQUIRES: Int64
10198
# RUN: split-file %s %t
10299
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl

test/Feature/HLSLLib/sign.32.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ DescriptorSets:
173173
...
174174
#--- end
175175

176-
# Bug https://github.com/microsoft/DirectXShaderCompiler/issues/7512
176+
# Bug https://github.com/microsoft/DirectXShaderCompiler/issues/7755
177177
# XFAIL: DXC-Vulkan
178178

179179
# We're generating invalid SPIRV for this. I have _no_ idea why this isn't

test/Feature/HLSLLib/sign.int16.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ DescriptorSets:
9494
...
9595
#--- end
9696

97-
# Bug https://github.com/microsoft/DirectXShaderCompiler/issues/7512
97+
# Bug https://github.com/microsoft/DirectXShaderCompiler/issues/7755
9898
# XFAIL: DXC-Vulkan
9999

100100
# REQUIRES: Int16

test/Feature/HLSLLib/sign.int64.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ DescriptorSets:
9494
...
9595
#--- end
9696

97-
# Bug https://github.com/microsoft/DirectXShaderCompiler/issues/7512
97+
# Bug https://github.com/microsoft/DirectXShaderCompiler/issues/7755
9898
# XFAIL: DXC-Vulkan
9999

100100
# REQUIRES: Int64

0 commit comments

Comments
 (0)