[Vulkan] Remove XFAILs for counter tests (#467)

Counter variable in Clang when targeting Vulkan is now implemented. See
llvm/llvm-project#137032. This removes the
XFAIL from tests that are now passing.

Note that inc_counter_array.test is still failing, but for a different
resson. A new bug was opened to address that issue.

However, a new test is added to test counter arrays.

Author: s-perron

test/Feature/StructuredBuffer/dec_counter.test

@@ -34,9 +34,6 @@ DescriptorSets:
 ...
 #--- end
 
-# Unimplemented https://github.com/llvm/llvm-project/issues/137032
-# XFAIL: Clang && Vulkan
-
 # Offload tests are missing support for counters on Metal
 # Unimplemented https://github.com/llvm/offload-test-suite/issues/304
 # XFAIL: Metal

test/Feature/StructuredBuffer/inc_counter.test

@@ -34,9 +34,6 @@ DescriptorSets:
 ...
 #--- end
 
-# Unimplemented https://github.com/llvm/llvm-project/issues/137032
-# XFAIL: Clang && Vulkan
-
 # Offload tests are missing support for counters on Metal
 # Unimplemented https://github.com/llvm/offload-test-suite/issues/304
 # XFAIL: Metal

test/Feature/StructuredBuffer/inc_counter_array.test

@@ -40,7 +40,7 @@ DescriptorSets:
 ...
 #--- end
 
-# Unimplemented https://github.com/llvm/llvm-project/issues/137032
+# Bug https://github.com/llvm/llvm-project/issues/162841
 # XFAIL: Clang && Vulkan
 
 # Offload tests are missing support for counters and resource arrays on Metal
@@ -62,7 +62,7 @@ DescriptorSets:
 # CHECK: Name: Out
 # CHECK: Counters: [ 1, 2, 3, 4 ]
 # CHECK: Data:
-      - [ 0x0 ]
-      - [ 0x1 ]
-      - [ 0x2 ]
-      - [ 0x3 ]
+# CHECK-NEXT: - [ 0x0 ]
+# CHECK-NEXT: - [ 0x1 ]
+# CHECK-NEXT: - [ 0x2 ]
+# CHECK-NEXT: - [ 0x3 ]

test/Feature/StructuredBuffer/inc_counter_array_imm_idx.test

@@ -0,0 +1,70 @@
+#--- source.hlsl
+
+// This test verifies handling of resource arrays when the
+// resource type has a counter.
+
+RWStructuredBuffer<int> Out[4] : register(u0);
+
+[numthreads(4,1,1)]
+void main(uint GI : SV_GroupIndex) {
+  Out[0].IncrementCounter();
+
+  Out[1].IncrementCounter();
+  Out[1].IncrementCounter();
+
+  Out[2].IncrementCounter();
+  Out[2].IncrementCounter();
+  Out[2].IncrementCounter();
+
+  Out[3].IncrementCounter();
+  Out[3].IncrementCounter();
+  Out[3].IncrementCounter();
+  Out[3].IncrementCounter();
+}
+
+//--- pipeline.yaml
+---
+Shaders:
+  - Stage: Compute
+    Entry: main
+    DispatchSize: [1, 1, 1]
+Buffers:
+  - Name: Out
+    Format: Hex32
+    Stride: 4
+    ArraySize: 4
+    ZeroInitSize: 4
+
+DescriptorSets:
+  - Resources:
+    - Name: Out
+      Kind: RWStructuredBuffer
+      HasCounter: true
+      DirectXBinding:
+        Register: 0
+        Space: 0
+      VulkanBinding:
+        Binding: 0
+        CounterBinding: 1
+...
+#--- end
+
+# Offload tests are missing support for counters and resource arrays on Metal
+# Unimplemented https://github.com/llvm/offload-test-suite/issues/304
+# Unimplemented https://github.com/llvm/offload-test-suite/issues/305
+# XFAIL: Metal
+
+# RUN: split-file %s %t
+# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
+# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s %if DirectX %{ --check-prefixes=CHECK,DX-CHECK %}
+
+# DX-CHECK: Creating UAV: { Size = 4100, Register = u0, Space = 0, HasCounter = 1 }
+# DX-CHECK: UAV: HeapIdx = 0 EltSize = 4 NumElts = 1 HasCounter = 1
+
+# CHECK: Name: Out
+# CHECK: Counters: [ 4, 8, 12, 16 ]
+# CHECK: Data:
+# CHECK-NEXT: - [ 0x0 ]
+# CHECK-NEXT: - [ 0x0 ]
+# CHECK-NEXT: - [ 0x0 ]
+# CHECK-NEXT: - [ 0x0 ]

test/Tools/Offloader/missing-counter-binding.test

@@ -31,9 +31,6 @@ DescriptorSets:
 ...
 #--- end
 
-# Unimplemented https://github.com/llvm/llvm-project/issues/137032
-# XFAIL: Clang && Vulkan
-
 # REQUIRES: Vulkan
 # RUN: split-file %s %t
 # RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl