Skip to content

Commit b8a4e82

Browse files
authored
Enable implicit binding tests for Clang-DXC (#212)
Enables implicit resource binding tests for Clang-DXC.
1 parent 4bfffe4 commit b8a4e82

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

test/Feature/ImplicitBindings/all-implicit.test

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,11 @@ DescriptorSets:
6868
...
6969
#--- end
7070

71-
# UNSUPPORTED: Clang
71+
# Clang's Vulkan implicit binding is not yet implemented.
72+
# UNSUPPORTED: Clang-Vulkan
7273

7374
# CBuffer bindings seem to be broken under metal
74-
# https://github.com/llvm-beanz/offload-test-suite/issues/55
75+
# https://github.com/llvm/offload-test-suite/issues/55
7576
# UNSUPPORTED: Metal
7677

7778
# RUN: split-file %s %t

test/Feature/ImplicitBindings/simple-resources.test

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,19 @@ DescriptorSets:
6666
...
6767
#--- end
6868

69-
# UNSUPPORTED: Clang
69+
# Clang's Vulkan implicit binding is not yet implemented.
70+
# UNSUPPORTED: Clang-Vulkan
7071

7172
# DXC's vulkan backend doesn't drop unused bindings, so it isn't possible to
7273
# specify descriptor sets that are valid for both DirectX and Vulkan there.
7374
# UNSUPPORTED: DXC-Vulkan
7475

76+
# CBuffer bindings seem to be broken under metal
77+
# https://github.com/llvm/offload-test-suite/issues/55
78+
# UNSUPPORTED: Metal
79+
7580
# RUN: split-file %s %t
76-
# RUN: %if !Vulkan %{ %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl %}
77-
# RUN: %if Vulkan %{ %dxc_target -T cs_6_0 -fspv-target-env=vulkan1.3 -fvk-use-scalar-layout -Fo %t.o %t/source.hlsl %}
81+
# RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/source.hlsl
7882
# RUN: %offloader %t/pipeline.yaml %t.o | FileCheck %s
7983

8084
# CHECK: Name: BufD

0 commit comments

Comments
 (0)