Skip to content

Conversation

kmpeng
Copy link
Contributor

@kmpeng kmpeng commented Jul 17, 2025

Closes #109.

Adds a test for AddUint64 testing UInt32 type. Values primarily pulled from HLK tests.
Need to remove XFAILs after #292 and #344 are fixed.

Copy link
Contributor

@bob80905 bob80905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to, instead, test an overflow case with a constant-folding variant?

Copy link
Contributor

@bob80905 bob80905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for linking those issues

Copy link
Collaborator

@spall spall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kmpeng kmpeng merged commit 41fd913 into llvm:main Aug 12, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for AddUint64
3 participants