Skip to content

Conversation

kmpeng
Copy link
Contributor

@kmpeng kmpeng commented Aug 8, 2025

Closes #163.

Adds tests for min testing 16 bit int types, half, 32 bit types, 64 bit int types, and double. Most values for 16 bit int and 32 bit int pulled from HLK tests. Didn't use HLK test inputs for half and float because they were mostly nan/inf/denorm values. No HLK tests for 64 bit int and double.
Need to remove XFAIL after #7691 is fixed.

@kmpeng kmpeng marked this pull request as ready for review August 9, 2025 02:38
Copy link
Collaborator

@spall spall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment on other float sizes; otherwise looks good

Copy link
Collaborator

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few small comments on run lines.

Copy link
Collaborator

@spall spall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kmpeng kmpeng merged commit b042c9d into llvm:main Aug 18, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for min
4 participants