[WARP] Make default WARP version "Last Known Good" #343
Conversation
We've encountered a fair number of problems with the System as the default verison of WARP, instead using a Last Known Good will hopefully make it easier for contributors to get up and working. This change adds two new special versions for the `WARP_VERSION` option: `LKG` and `Latest`. At the moment the `LKG` version is 1.0.14.2, which is also the latest released version. This PR also adds a set of build jobs to run periodic builds with the current WARP pre-release build. Fixes llvm#340
This creates the destination directory if it doesn't already exist.
The WARP bug that caused firstbithigh to fail was fixed for x86 in 1.0.14, but still exists on arm64.
On 1.0.14 the `length` test is failing.
|
@damyanp and/or @Icohedron, could you give this a glance again? Getting it working required a bit more change than I expected. For x86_64 we need to go back to WARP 1.0.10.1 as the LKG because I'm seeing some odd issues with the length test that looks like For arm64 we set 1.0.14.2 as the LKG version because it passes all the tests that 1.0.10.1 does, and 1.0.10.1 doesn't have an arm64 binary in the NuGet package. I've already talked with @jenatali about the firstbithigh issue that was fixed for x86 but persists on arm64. I'll also put together bugs on the WARP issues we're seeing here with the latest WARP running our length test and @kmpeng's PR (#316). |
|
Thanks for the tag. Please keep me in the loop on any WARP bugs. If there's minimal reproducers then they should be fast to investigate and we can turn around NuGet packages fairly quickly. |
We've encountered a fair number of problems with the System as the default verison of WARP, instead using a Last Known Good will hopefully make it easier for contributors to get up and working.
This change adds two new special versions for the
WARP_VERSIONoption:LKGandLatest. At the moment theLKGversion is 1.0.14.2, which is also the latest released version.This PR also adds a set of build jobs to run periodic builds with the current WARP pre-release build.
The firstbithigh test fails on arm64 with all versions of WARP due to a bug that was fixed for x86 in 1.0.14. This change reduces the scope of the XFAIL to just WARP on arm64.
Fixes #340