Fix no return in NDEBUG builds (#4011)

IanWood1 · web-flow · commit 217d0a8232a7 · 2025-02-11T11:33:43.000-06:00
Uses `llvm_unreachable` to mark path unreachable to fix compiler error

```
DefaultDomainQtoZ.cpp:194:1: error: non-void function does not return a value in all control paths
```

Signed-off-by: Ian Wood &lt;ianwood2024@u.northwestern.edu&gt;
diff --git a/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp b/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp
@@ -190,7 +190,7 @@ Type getTorchScalarType(
   if (isa<FloatType>(elementTypeForGivenTensor))
     return rewriter.getType<Torch::FloatType>();
 
-  assert(false && "dtype for given tensor expected to be either int or float");
+  llvm_unreachable("dtype for given tensor expected to be either int or float");
 }
 
 Value extractTorchScalar(

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ Type getTorchScalarType(`
`190`	`190`	`if (isa<FloatType>(elementTypeForGivenTensor))`
`191`	`191`	`return rewriter.getType<Torch::FloatType>();`
`192`	`192`
`193`		`- assert(false && "dtype for given tensor expected to be either int or float");`
	`193`	`+ llvm_unreachable("dtype for given tensor expected to be either int or float");`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`Value extractTorchScalar(`