Addressed the feedback

Author: amemov

lib/Conversion/TorchToLinalg/Linear.cpp

@@ -1769,7 +1769,7 @@ class ConvertAtenOuterOp : public OpConversionPattern<AtenOuterOp> {
 
     Location loc = op->getLoc();
     Value lhs = adaptor.getSelf();
-    Value rhs = op->getOperand(1);
+    Value rhs = adaptor.getVec2();
 
     if (failed(verifyLinalgCompatibleTypes(op, rewriter))) {
       return failure();
@@ -1790,8 +1790,10 @@ class ConvertAtenOuterOp : public OpConversionPattern<AtenOuterOp> {
     Type newResultType = getTypeConverter()->convertType(op.getType());
 
     // Create a zero-initialized tensor with shape [lhsDim, rhsDim]
-    Value initTensor = createInitTensor(
-        rewriter, loc, ValueRange{lhsDim, rhsDim}, elementType, NULL);
+    SmallVector<OpFoldResult> resultShape =
+        getAsOpFoldResult(ValueRange{lhsDim, rhsDim});
+    Value initTensor =
+        rewriter.create<tensor::EmptyOp>(loc, resultShape, elementType);
 
     // Set up affine indexing maps:
     // We create a 2D loop iteration space. For the lhs, we use the first index

projects/pt1/python/torch_mlir_e2e_test/test_suite/matmul.py

@@ -942,3 +942,37 @@ def forward(self, lhs, rhs):
 @register_test_case(module_factory=lambda: AtenOuter())
 def AtenOuter_basic(module, tu: TestUtils):
     module.forward(tu.rand(3), tu.rand(3))
+
+
+# ==============================================================================
+
+
+class AtenOuterDynamic(torch.nn.Module):
+    def __init__(self):
+        super().__init__()
+
+    @export
+    @annotate_args(
+        [
+            None,
+            ([-1], torch.float32, True),
+            ([-1], torch.float32, True),
+        ]
+    )
+    def forward(self, lhs, rhs):
+        return torch.outer(lhs, rhs)
+
+
+@register_test_case(module_factory=lambda: AtenOuterDynamic())
+def AtenOuterDynamic_basic(module, tu: TestUtils):
+    module.forward(tu.rand(5), tu.rand(5))
+
+
+@register_test_case(module_factory=lambda: AtenOuterDynamic())
+def AtenOuterDynamic_lhs_larger(module, tu: TestUtils):
+    module.forward(tu.rand(7), tu.rand(4))
+
+
+@register_test_case(module_factory=lambda: AtenOuterDynamic())
+def AtenOuterDynamic_rhs_larger(module, tu: TestUtils):
+    module.forward(tu.rand(2), tu.rand(6))