[TORCH] Add support for fix Op (#4195)

- Added the support for fix Op
- Since this is an alias for torch.trunc
- Added the e2e test

This implementation addresses and closes
#4193

---------

Signed-off-by: sharavana20 <[email protected]>

Author: sharavana20

include/torch-mlir/Dialect/Torch/IR/GeneratedTorchOps.td

@@ -4608,6 +4608,51 @@ def Torch_AtenTrunc_Op : Torch_Op<"aten.trunc_", [
   }];
 }
 
+def Torch_AtenFixOp : Torch_Op<"aten.fix", [
+    AllowsTypeRefinement,
+    HasValueSemantics,
+    ReadOnly
+  ]> {
+  let summary = "Generated op for `aten::fix : (Tensor) -> (Tensor)`";
+  let arguments = (ins
+    AnyTorchTensorType:$self
+  );
+  let results = (outs
+    AnyTorchOptionalTensorType:$result
+  );
+  let hasCustomAssemblyFormat = 1;
+  let extraClassDefinition = [{
+    ParseResult AtenFixOp::parse(OpAsmParser &parser, OperationState &result) {
+      return parseDefaultTorchOp(parser, result, 1, 1);
+    }
+    void AtenFixOp::print(OpAsmPrinter &printer) {
+      printDefaultTorchOp(printer, *this, 1, 1);
+    }
+  }];
+}
+
+def Torch_AtenFix_Op : Torch_Op<"aten.fix_", [
+    IsTrailingUnderscoreInplaceVariant,
+    AllowsTypeRefinement
+  ]> {
+  let summary = "Generated op for `aten::fix_ : (Tensor) -> (Tensor)`";
+  let arguments = (ins
+    Torch_NonValueTensorType:$self
+  );
+  let results = (outs
+    AnyTorchOptionalNonValueTensorType:$result
+  );
+  let hasCustomAssemblyFormat = 1;
+  let extraClassDefinition = [{
+    ParseResult AtenFix_Op::parse(OpAsmParser &parser, OperationState &result) {
+      return parseDefaultTorchOp(parser, result, 1, 1);
+    }
+    void AtenFix_Op::print(OpAsmPrinter &printer) {
+      printDefaultTorchOp(printer, *this, 1, 1);
+    }
+  }];
+}
+
 def Torch_AtenSpecialExpm1Op : Torch_Op<"aten.special_expm1", [
     AllowsTypeRefinement,
     HasValueSemantics,

lib/Dialect/Torch/Transforms/AbstractInterpLibrary.cpp

@@ -6710,6 +6710,10 @@ StringRef mlir::torch::Torch::getAbstractInterpLibrary() {
 "    %0 = call @__torch__.torch.jit._shape_functions.unary(%arg0) : (!torch.list<int>) -> !torch.list<int>\n"
 "    return %0 : !torch.list<int>\n"
 "  }\n"
+"  func.func @\"__torch_mlir_shape_fn.aten.fix\"(%arg0: !torch.list<int>) -> !torch.list<int> {\n"
+"    %0 = call @__torch__.torch.jit._shape_functions.unary(%arg0) : (!torch.list<int>) -> !torch.list<int>\n"
+"    return %0 : !torch.list<int>\n"
+"  }\n"
 "  func.func @\"__torch_mlir_shape_fn.aten.log\"(%arg0: !torch.list<int>) -> !torch.list<int> {\n"
 "    %0 = call @__torch__.torch.jit._shape_functions.unary(%arg0) : (!torch.list<int>) -> !torch.list<int>\n"
 "    return %0 : !torch.list<int>\n"
@@ -12357,6 +12361,10 @@ StringRef mlir::torch::Torch::getAbstractInterpLibrary() {
 "    %0:2 = torch.prim.TupleUnpack %arg0 : !torch.tuple<int, int> -> !torch.int, !torch.int\n"
 "    return %0#1 : !torch.int\n"
 "  }\n"
+"  func.func @\"__torch_mlir_dtype_fn.aten.fix\"(%arg0: !torch.tuple<int, int>) -> !torch.int {\n"
+"    %0:2 = torch.prim.TupleUnpack %arg0 : !torch.tuple<int, int> -> !torch.int, !torch.int\n"
+"    return %0#1 : !torch.int\n"
+"  }\n"
 "  func.func @\"__torch_mlir_dtype_fn.aten.clamp_max\"(%arg0: !torch.tuple<int, int>, %arg1: !torch.number) -> !torch.int {\n"
 "    %int4 = torch.constant.int 4\n"
 "    %int11 = torch.constant.int 11\n"

lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp

@@ -8780,6 +8780,19 @@ class DecomposeAtenTruncOp : public OpRewritePattern<AtenTruncOp> {
 };
 } // namespace
 
+namespace {
+// fix Op is an alias for trunc Op
+class DecomposeAtenFixOp : public OpRewritePattern<AtenFixOp> {
+  using OpRewritePattern::OpRewritePattern;
+  LogicalResult matchAndRewrite(AtenFixOp op,
+                                PatternRewriter &rewriter) const override {
+    Value self = op.getSelf();
+    rewriter.replaceOpWithNewOp<AtenTruncOp>(op, op.getType(), self);
+    return success();
+  }
+};
+} // namespace
+
 namespace {
 // decompose `signbit(x)` to `view.dtype(x, si32/si64) < 0 `
 class DecomposeAtenSignbitOp : public OpRewritePattern<AtenSignbitOp> {
@@ -12085,6 +12098,7 @@ class DecomposeComplexOpsPass
     addPatternIfTargetOpIsIllegal<DecomposeAtenRad2degOp>(patterns);
     addPatternIfTargetOpIsIllegal<DecomposeAtenCosineSimilarityOp>(patterns);
     addPatternIfTargetOpIsIllegal<DecomposeAtenTruncOp>(patterns);
+    addPatternIfTargetOpIsIllegal<DecomposeAtenFixOp>(patterns);
     addPatternIfTargetOpIsIllegal<DecomposeAtenSignbitOp>(patterns);
     addPatternIfTargetOpIsIllegal<DecomposeAtenFracOp>(patterns);
     addPatternIfTargetOpIsIllegal<DecomposeAtenCopysignTensorOp>(patterns);

lib/Dialect/Torch/Transforms/LowerToBackendContract.cpp

@@ -550,6 +550,7 @@ static void markDecomposedOpsAsIllegal(MLIRContext *context,
   target.addIllegalOp<AtenRad2degOp>();
   target.addIllegalOp<AtenCosineSimilarityOp>();
   target.addIllegalOp<AtenTruncOp>();
+  target.addIllegalOp<AtenFixOp>();
   target.addIllegalOp<AtenSignbitOp>();
   target.addIllegalOp<AtenFracOp>();
   target.addIllegalOp<AtenCopysignTensorOp>();

projects/pt1/e2e_testing/xfail_sets.py

@@ -1694,6 +1694,8 @@
     "ElementwiseSinhModule_basic",
     "ElementwiseTruncIntModule_basic",
     "ElementwiseTruncModule_basic",
+    "ElementwiseFixModule_basic",
+    "ElementwiseFixIntModule_basic",
     "ElementwiseLogSigmoidModule_basic",
     "ElementwiseHardshrinkStaticModule_basic",
     "ElementwiseSoftshrinkStaticModule_basic",
@@ -2049,6 +2051,8 @@
     "ElementwiseTernaryStaticShapeModule_basic",
     "ElementwiseTruncModule_basic",
     "ElementwiseTruncIntModule_basic",
+    "ElementwiseFixModule_basic",
+    "ElementwiseFixIntModule_basic",
     "ElementwiseSgnModule_basic",
     "ElementwiseSignIntModule_basic",
     "AddCDivModule_basic",
@@ -2900,6 +2904,8 @@
     "ElementwiseCoshModule_basic",
     "ElementwiseTruncIntModule_basic",
     "ElementwiseTruncModule_basic",
+    "ElementwiseFixModule_basic",
+    "ElementwiseFixIntModule_basic",
     "ElementwiseDequantizePerChannelModule_basic",
     "ElementwiseDequantizePerTensorModule_basic",
     "ElementwiseDivTensorRoundingModeFloorIntStaticModule_basic",
@@ -4356,6 +4362,8 @@
     "ElementwiseToDtypeI64ToUI8Module_basic",
     "ElementwiseTruncIntModule_basic",
     "ElementwiseTruncModule_basic",
+    "ElementwiseFixModule_basic",
+    "ElementwiseFixIntModule_basic",
     "ElementwiseUnaryIntModule_basic",
     "ElementwiseUnsqueezeNegDimsModule_basic",
     "ElementwiseWhereScalarOtherModule_basic",

projects/pt1/python/torch_mlir/jit_ir_importer/build_tools/abstract_interp_lib_gen.py

@@ -319,6 +319,9 @@ def aten〇ceil〡shape(self: List[int]) -> List[int]:
 def aten〇trunc〡shape(self: List[int]) -> List[int]:
     return upstream_shape_functions.unary(self)
 
+def aten〇fix〡shape(self: List[int]) -> List[int]:
+    return upstream_shape_functions.unary(self)
+
 def aten〇log〡shape(self: List[int]) -> List[int]:
     return upstream_shape_functions.unary(self)
 
@@ -3108,6 +3111,11 @@ def aten〇trunc〡dtype(self_rank_dtype: Tuple[int, int]) -> int:
     self_rank, self_dtype = self_rank_dtype
     return self_dtype
 
+@check_dtype_function(_check_tensors_with_the_same_dtype(num_of_tensors=1))
+def aten〇fix〡dtype(self_rank_dtype: Tuple[int, int]) -> int:
+    self_rank, self_dtype = self_rank_dtype
+    return self_dtype
+
 @check_dtype_function(_check_tensors_with_the_same_dtype(num_of_tensors=1, max=0))
 def aten〇clamp_max〡dtype(self_rank_dtype: Tuple[int, int], max: Union[int, float, complex]) -> int:
     self_rank, self_dtype = self_rank_dtype

projects/pt1/python/torch_mlir/jit_ir_importer/build_tools/torch_ods_gen.py

@@ -452,6 +452,7 @@ def emit_with_mutating_variants(key, **kwargs):
     emit_with_mutating_variants("aten::ceil : (Tensor) -> (Tensor)", has_folder=True)
     emit_with_mutating_variants("aten::round : (Tensor) -> (Tensor)", has_folder=True)
     emit_with_mutating_variants("aten::trunc : (Tensor) -> (Tensor)", has_folder=True)
+    emit_with_mutating_variants("aten::fix : (Tensor) -> (Tensor)")
     emit("aten::special_expm1 : (Tensor) -> (Tensor)")
     emit_with_mutating_variants(
         "aten::sign : (Tensor) -> (Tensor)", has_canonicalizer=True

projects/pt1/python/torch_mlir_e2e_test/test_suite/elementwise.py

@@ -2900,6 +2900,49 @@ def ElementwiseTruncIntModule_basic(module, tu: TestUtils):
 # ==============================================================================
 
 
+class ElementwiseFixModule(torch.nn.Module):
+    def __init__(self):
+        super().__init__()
+
+    @export
+    @annotate_args(
+        [
+            None,
+            ([5], torch.float32, True),
+        ]
+    )
+    def forward(self, a):
+        return torch.fix(a)
+
+
+@register_test_case(module_factory=lambda: ElementwiseFixModule())
+def ElementwiseFixModule_basic(module, tu: TestUtils):
+    module.forward(torch.tensor([torch.nan, torch.inf, -torch.inf, 2, 0.5]))
+
+
+class ElementwiseFixIntModule(torch.nn.Module):
+    def __init__(self):
+        super().__init__()
+
+    @export
+    @annotate_args(
+        [
+            None,
+            ([2, 3], torch.int64, True),
+        ]
+    )
+    def forward(self, a):
+        return torch.fix(a)
+
+
+@register_test_case(module_factory=lambda: ElementwiseFixIntModule())
+def ElementwiseFixIntModule_basic(module, tu: TestUtils):
+    module.forward(tu.randint(2, 3, low=0, high=500))
+
+
+# ==============================================================================
+
+
 class ElementwiseSignbitModule(torch.nn.Module):
     def __init__(self):
         super().__init__()