Skip to content

Commit ad4b9e0

Browse files
committed
Minor fixes
1 parent f8080bd commit ad4b9e0

File tree

4 files changed

+3
-16
lines changed

4 files changed

+3
-16
lines changed

include/torch-mlir/Dialect/Torch/IR/GeneratedPrimOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,7 @@ def Torch_PrimRaiseExceptionOp : Torch_Op<"prim.RaiseException", [
175175
}
176176

177177
def Torch_PrimUninitializedOp : Torch_Op<"prim.Uninitialized", [
178+
NoSideEffect,
178179
AllowsTypeRefinement,
179180
HasValueSemantics
180181
]> {
@@ -185,7 +186,6 @@ def Torch_PrimUninitializedOp : Torch_Op<"prim.Uninitialized", [
185186
AnyTorchType:$result
186187
);
187188
let assemblyFormat = " attr-dict `:` qualified(type($result))";
188-
let hasCanonicalizer = 1;
189189
}
190190

191191
def Torch_PrimUncheckedCastOp : Torch_Op<"prim.unchecked_cast", [

lib/Dialect/Torch/IR/TorchOps.cpp

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1037,20 +1037,6 @@ void PrimTupleIndexOp::getCanonicalizationPatterns(RewritePatternSet &patterns,
10371037
});
10381038
}
10391039

1040-
//===----------------------------------------------------------------------===//
1041-
// PrimUninitializedOp
1042-
//===----------------------------------------------------------------------===//
1043-
1044-
void PrimUninitializedOp::getCanonicalizationPatterns(
1045-
RewritePatternSet &patterns, MLIRContext *context) {
1046-
patterns.add(+[](PrimUninitializedOp op, PatternRewriter &rewriter) {
1047-
if (!op.use_empty())
1048-
return failure();
1049-
rewriter.eraseOp(op);
1050-
return success();
1051-
});
1052-
}
1053-
10541040
//===----------------------------------------------------------------------===//
10551041
// PrimTupleUnpackOp
10561042
//===----------------------------------------------------------------------===//

python/torch_mlir/dialects/torch/importer/jit_ir/build_tools/torch_ods_gen.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ def emit(key, **kwargs):
414414
emit("prim::max.self_int : (int[]) -> (int)")
415415
emit("prim::max.int : (int, int) -> (int)")
416416
emit("prim::RaiseException : (str) -> ()")
417-
emit("prim::Uninitialized : () -> (Any)", has_canonicalizer=True)
417+
emit("prim::Uninitialized : () -> (Any)", traits=["NoSideEffect"])
418418
emit("prim::unchecked_cast : (t) -> (t)",
419419
traits=["DeclareOpInterfaceMethods<CastOpInterface>"])
420420
emit("prim::Print : (...) -> ()")

python/torch_mlir/dialects/torch/importer/jit_ir/csrc/torch_to_mlir_utils.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include "function_importer.h"
1212
#include "ivalue_importer.h"
1313

14+
#include <ATen/TensorUtils.h>
1415
#include <unordered_map>
1516

1617
#include "mlir_utils.h"

0 commit comments

Comments
 (0)