[torch-mlir maintainers] Need to reassess code ownership, reviews and who is active #4288
Replies: 6 comments
-
Hey Stella, Eric and I continue to be active on TorchToTosa. |
Beta Was this translation helpful? Give feedback.
-
Thanks, @stellaraccident for putting up this thread. I'd be happy to get added to a list of code owners and prioritize reviewing and helping land PR's. I've been a bit busy with other work, too, but we definitely need someone moving things along here. |
Beta Was this translation helpful? Give feedback.
-
I can continue to be a maintainer for the LTC work. Though, we've considered this work stable for a while now and are not actively contributing at this moment. We're actively using it though, so if things break, we can help with fixes |
Beta Was this translation helpful? Give feedback.
-
I am still maintaining the TorchToStablehlo and fx_importer script. These works are relatively stable, and there are not many active contributions. In particular, stablehlo is also affected by the interface changes brought about by llvm bump, which I will continue to pay attention to. |
Beta Was this translation helpful? Give feedback.
-
Hi Stella, I haven’t been involved with torch_mlir and/or its bazel build for over two years. Please feel free to remove me from the maintainers list. Thank you! |
Beta Was this translation helpful? Give feedback.
-
Hi Stella, I am a newish contributor to |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi Folks, @ivangarcia44 has posted an RFC for fixes to code ownership and pull requests. I have to admit that for the last 6 months or so, I have been fully engaged with my day job and only responding to direct pings vs generally watching the issue/PR queue. I also know that over the last couple of years, many of the historic contributors to the project have changed jobs/companies/projects -- so much so that a review of the code_owners.md file reads like a historical novel.
Based on the issue above, I did do a look through the PR queue, and it isn't pretty. I wanted to start a general discussion vs focus on the specific solution outlined in the RFC as we clearly have some work to do generally.
Tactically, I went ahead and approved #4259, which looked like it had a pretty thorough review and tests. I think whatever we decide here about who is active and any needed project organization changes, I think that we should aim to fix the code_owners.md file and include contributing guidance in the spirit of what is proposed above in #4284.
Starting with current code_owners.md:
Can you respond to this thread if you still intend to be active with reviews for the part of the project you are listed for? I have a pretty good idea on a few of these, but I don't want to presume.
All parts not covered by anyone else
Stella Laurenzo (@stellaraccident)
Sean Silva (@silvasean) - emeritus
torch dialect and other core IR pieces, Python bindings/API, JIT IR importer
Stella Laurenzo (@stellaraccident)
TorchToLinalg, Shape inference, Dtype refinement, MaximizeValueSemantics
Ramiro Leal-Cavazos (@ramiro050)
CI / Build system / Packaging
Anush Elangovan (@powderluv)
TorchToTOSA
Eric Kunze (@eric-k256)
Suraj Sudhir (@sjarus)
TorchToStablehlo
Tianyo Kwok (@tanyokwok)
Xiafei Qiu (@qiuxiafei)
Ziheng Jiang (@ZihengJiang)
Jiawei Wu (@Vremold)
LTC
Antonio Kim (@antoniojkim)
Ke Deng (@ke1337)
Bazel build
Sambhav Jain (@sjain-stanford)
Ahmed Taei (@asaadaldien)
LLVM Integrate
Ashay Rane (@ashay)
Note areas of the code you work on
If you/your company is investing in some piece of code specifically, please comment on that. It helps everyone to know which parts of the code are relatively quiescent and what is receiving a lot of active investment. I see a lot of new handles (to me) making patches and doing reviews. Feel free to speak up, especially if not one of the historic/original contributors.
And adding people I know to be active/lurking
@vivekkhandelwal1
@zjgarvey
@rsuderman
@qedawkins
@sjain-stanford
@MaheshRavishankar
Followup?
We stopped having community meetings a long time ago. Would it be useful to folks to have a get together of contributors at some point (video, etc) just to say hi and associate faces/names/work? I think it is a relatively small group of people who actively contribute to this project, and I feel like if folks are better connected to each other, that will yield improvements in reviews, etc on its own.
Beta Was this translation helpful? Give feedback.
All reactions