Skip to content

Fix torch.operator names #4235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix torch.operator names #4235

wants to merge 1 commit into from

Conversation

bjacob
Copy link
Contributor

@bjacob bjacob commented Jun 18, 2025

This implements the fix suggested by @heshuju in #4108.

It fixes an issue that was blocking the LLVM integrate in IREE. https://github.com/iree-org/iree/actions/runs/15626565095/job/44156258415?pr=21092

@bjacob
try-4108
1d4a9ef 
Signed-off-by: Benoit Jacob <[email protected]>
@bjacob bjacob mentioned this pull request Jun 18, 2025
Closed
@rsuderman
Copy link
Contributor

We should change this at the reduce op variants level instead.

torch-mlir/lib/Dialect/Torch/Transforms/ReduceOpVariants.cpp

Line 240 in 0c29ccf

"torch.aten._scaled_dot_product_flash_attention_for_cpu",

Instead of matching to torch.aten._scaled_dot_product_flash_attention_for_cpu to aten._scaled_dot_product_flash_attention_for_cpu. Or preferably match with both. I am guessing that the ingestion can generate for both.

The above test fails because it assumes a torch prefix to the operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsuderman rsuderman Awaiting requested review from rsuderman

@vivekkhandelwal1 vivekkhandelwal1 Awaiting requested review from vivekkhandelwal1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjacob @rsuderman