uninstrument spans that are performed in memory (usually 3-4us) (#1014)

* uninstrument spans that are performed in memory (usually 3-4us)

* instrument actual storage calls

Author: dinmukhamedm

app-server/src/storage/s3.rs

@@ -2,6 +2,7 @@ use anyhow::Result;
 use async_trait::async_trait;
 use aws_sdk_s3::Client;
 use std::{pin::Pin, sync::Arc};
+use tracing::instrument;
 
 use crate::{
     mq::{MessageQueue, MessageQueueTrait},
@@ -53,6 +54,7 @@ impl super::StorageTrait for S3Storage {
         Ok(self.get_url(key))
     }
 
+    #[instrument(skip(self, data))]
     async fn store_direct(&self, bucket: &str, key: &str, data: Vec<u8>) -> Result<String> {
         // Direct storage method used by the payload worker
         self.client

app-server/src/traces/consumer.rs

@@ -368,7 +368,11 @@ async fn process_batch(
                     send_trace_updates(&updated_traces, &sse_connections).await;
                 }
                 Err(e) => {
-                    log::error!("Failed to upsert trace statistics to PostgreSQL: {:?}", e);
+                    log::error!(
+                        "Failed to upsert trace statistics to PostgreSQL. project_id: [{}], error: [{:?}]",
+                        project_id,
+                        e
+                    );
                 }
             }
         }

app-server/src/traces/provider/mod.rs

@@ -2,14 +2,12 @@ mod langchain;
 mod openai;
 
 use serde_json::Value;
-use tracing::instrument;
 
 use crate::{
     db::spans::{Span, SpanType},
     traces::provider::langchain::is_langchain_span,
 };
 
-#[instrument(skip(span))]
 pub fn convert_span_to_provider_format(span: &mut Span) {
     if span.span_type != SpanType::LLM {
         return;

app-server/src/traces/spans.rs

@@ -10,7 +10,6 @@ use indexmap::IndexMap;
 use regex::Regex;
 use serde::{Deserialize, Serialize};
 use serde_json::{Value, json};
-use tracing::instrument;
 use uuid::Uuid;
 
 use crate::{
@@ -754,7 +753,6 @@ impl Span {
         }
     }
 
-    #[instrument(skip(self, project_id, storage))]
     pub async fn store_payloads(&mut self, project_id: &Uuid, storage: Arc<Storage>) -> Result<()> {
         let payload_size_threshold = env::var("MAX_DB_SPAN_PAYLOAD_BYTES")
             .ok()

app-server/src/traces/utils.rs

@@ -123,7 +123,6 @@ fn is_top_span(span: &Span, attributes: &SpanAttributes) -> bool {
     first_in_ids && first_in_path
 }
 
-#[instrument(skip(span, span_usage, events))]
 pub fn prepare_span_for_recording(span: &mut Span, span_usage: &SpanUsage, events: &[Event]) -> () {
     events.iter().for_each(|event| {
         // Check if it's an exception event