Skip to content

Commit 02cd078

Browse files
committed
[ntuple] remove RClusterSummary::fColumnGroupID
1 parent 5cfe091 commit 02cd078

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

tree/ntuple/v7/inc/ROOT/RNTupleSerialize.hxx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ public:
8888
std::uint64_t fFirstEntry = 0;
8989
std::uint64_t fNEntries = 0;
9090
std::uint8_t fFlags = 0;
91-
/// -1 for "all columns"
92-
std::int32_t fColumnGroupID = -1;
9391
};
9492

9593
struct RClusterGroup {

tree/ntuple/v7/src/RNTupleSerialize.cxx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1145,7 +1145,6 @@ ROOT::Experimental::Internal::RNTupleSerializer::DeserializeClusterSummary(const
11451145

11461146
clusterSummary.fNEntries = nEntries;
11471147
clusterSummary.fFlags = flags;
1148-
clusterSummary.fColumnGroupID = -1;
11491148

11501149
return frameSize;
11511150
}
@@ -1512,7 +1511,7 @@ ROOT::Experimental::Internal::RNTupleSerializer::SerializePageList(void *buffer,
15121511
pos += SerializeListFramePreamble(nClusters, *where);
15131512
for (auto clusterId : physClusterIDs) {
15141513
const auto &clusterDesc = desc.GetClusterDescriptor(context.GetMemClusterId(clusterId));
1515-
RClusterSummary summary{clusterDesc.GetFirstEntryIndex(), clusterDesc.GetNEntries(), 0, -1};
1514+
RClusterSummary summary{clusterDesc.GetFirstEntryIndex(), clusterDesc.GetNEntries(), 0};
15161515
pos += SerializeClusterSummary(summary, *where);
15171516
}
15181517
pos += SerializeFramePostscript(buffer ? clusterSummaryFrame : nullptr, pos - clusterSummaryFrame);
@@ -1794,8 +1793,6 @@ ROOT::Experimental::Internal::RNTupleSerializer::DeserializePageList(const void
17941793
if (!result)
17951794
return R__FORWARD_ERROR(result);
17961795
bytes += result.Unwrap();
1797-
if (clusterSummary.fColumnGroupID >= 0)
1798-
return R__FAIL("sharded clusters are still unsupported");
17991796

18001797
RClusterDescriptorBuilder builder;
18011798
builder.ClusterId(clusterId).FirstEntryIndex(clusterSummary.fFirstEntry).NEntries(clusterSummary.fNEntries);

tree/ntuple/v7/test/ntuple_serialize.cxx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,6 @@ TEST(RNTuple, SerializeClusterSummary)
456456
EXPECT_EQ(summary.fFirstEntry, reco.fFirstEntry);
457457
EXPECT_EQ(summary.fNEntries, reco.fNEntries);
458458
EXPECT_EQ(summary.fFlags, reco.fFlags);
459-
EXPECT_EQ(summary.fColumnGroupID, reco.fColumnGroupID);
460459

461460
summary.fFlags |= 0x01;
462461
EXPECT_EQ(24u, RNTupleSerializer::SerializeClusterSummary(summary, buffer));

0 commit comments

Comments
 (0)