Fixing some test cases regarding Multi directional Broadcasting

Author: Neel-Shah-29

tmva/sofie/inc/TMVA/SOFIE_common.hxx

@@ -105,8 +105,7 @@ ETensorType GetTemplatedType(T /*obj*/ ){
 namespace UTILITY{
 template<typename T>
 T* Unidirectional_broadcast(const T* original_data, const std::vector<size_t> original_shape, const std::vector<size_t> target_shape);
-
-std::vector<size_t> Multidirectional_broadcast(std::vector<size_t> input1_shape, std::vector<size_t> input2_shape);
+std::vector<size_t> Multidirectional_broadcast(const std::vector<size_t> input1_shape, const std::vector<size_t> input2_shape);
 std::string Clean_name(std::string input_tensor_name);
 
 

tmva/sofie/src/SOFIE_common.cxx

@@ -137,9 +137,9 @@ T* UTILITY::Unidirectional_broadcast(const T* original_data, const std::vector<s
 
 
 
-std::vector<size_t>  UTILITY::Multidirectional_broadcast(std::vector<size_t> input1_shape,  std::vector<size_t> input2_shape)
+std::vector<size_t>  UTILITY::Multidirectional_broadcast(std::vector<size_t> input1_shape, std::vector<size_t> input2_shape)
 {
-   std::vector<size_t> input_shape = (input1_shape > input2_shape)?input1_shape:input2_shape;
+   std::vector<size_t> input_shape = (input1_shape.size() > input2_shape.size())?input1_shape:input2_shape;
    std::vector<size_t> output_shape(input_shape);
 
    if(input1_shape.size() < input2_shape.size()){
@@ -148,22 +148,16 @@ std::vector<size_t>  UTILITY::Multidirectional_broadcast(std::vector<size_t> inp
       while (input1_shape.size() < input2_shape.size()) {
          it = input1_shape.insert(it, 1);
       }
-      if(input1_shape.size()==input1_shape.size()){
-         UTILITY::Multidirectional_broadcast(input1_shape,input2_shape);
-      }
    }
    else if(input2_shape.size() < input1_shape.size()){
    // Check if input2_shape.size() < input1_shape.size() we insert in the shape vector values of 1 at the beginning of the tensor until input1_shape.size() == input2_shape.size()
       auto it = input2_shape.begin();
       while (input2_shape.size() < input1_shape.size()) {
          it = input2_shape.insert(it, 1);
       }
-      if(input1_shape.size()==input1_shape.size()){
-         UTILITY::Multidirectional_broadcast(input1_shape,input2_shape);
-      }
    }
       //check if both the input have same shape, nothing to do directly return the output_shape as the same shape.
-   else if(input1_shape.size() == input2_shape.size()){
+   if(input1_shape.size() == input2_shape.size()){
       if(input1_shape != input2_shape){
          //Check the shape values, if input1[i] not equal to input2[i] we have the result shape equal to input1[i] if input2[i] = 1 or viceversa
          for(size_t j = 0; j < input1_shape.size() ; j++){