Skip to content

Commit c745e30

Browse files
eguiraudetejedor
authored andcommitted
[TDF][NFC] Change start->begin, stop->end everywhere
1 parent 9ceee38 commit c745e30

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

tree/treeplayer/inc/ROOT/TDFInterface.hxx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -749,35 +749,35 @@ public:
749749
}
750750

751751
////////////////////////////////////////////////////////////////////////////
752-
/// \brief Creates a node that filters entries based on range: [start, stop)
752+
/// \brief Creates a node that filters entries based on range: [begin, end)
753753
/// \param[in] begin Initial entry number considered for this range.
754754
/// \param[in] end Final entry number (excluded) considered for this range. 0 means that the range goes until the end of the dataset.
755755
/// \param[in] stride Process one entry of the [begin, end) range every `stride` entries. Must be strictly greater than 0.
756756
///
757757
/// Note that in case of previous Ranges and Filters the selected range refers to the transformed dataset.
758758
/// Ranges are only available if EnableImplicitMT has _not_ been called. Multi-thread ranges are not supported.
759-
TInterface<TDFDetail::TRange<Proxied>> Range(unsigned int start, unsigned int stop, unsigned int stride = 1)
759+
TInterface<TDFDetail::TRange<Proxied>> Range(unsigned int begin, unsigned int end, unsigned int stride = 1)
760760
{
761761
// check invariants
762-
if (stride == 0 || (stop != 0 && stop < start))
763-
throw std::runtime_error("Range: stride must be strictly greater than 0 and stop must be greater than start.");
762+
if (stride == 0 || (end != 0 && end < begin))
763+
throw std::runtime_error("Range: stride must be strictly greater than 0 and end must be greater than begin.");
764764
if (ROOT::IsImplicitMTEnabled())
765765
throw std::runtime_error("Range was called with ImplicitMT enabled. Multi-thread ranges are not supported.");
766766

767767
auto df = GetDataFrameChecked();
768768
using Range_t = TDFDetail::TRange<Proxied>;
769-
auto RangePtr = std::make_shared<Range_t>(start, stop, stride, *fProxiedPtr);
769+
auto RangePtr = std::make_shared<Range_t>(begin, end, stride, *fProxiedPtr);
770770
df->Book(RangePtr);
771771
TInterface<TDFDetail::TRange<Proxied>> tdf_r(RangePtr, fImplWeakPtr, fValidCustomColumns, fDataSource);
772772
return tdf_r;
773773
}
774774

775775
////////////////////////////////////////////////////////////////////////////
776776
/// \brief Creates a node that filters entries based on range
777-
/// \param[in] stop Total number of entries that will be processed before stopping. 0 means "never stop".
777+
/// \param[in] end Final entry number (excluded) considered for this range. 0 means that the range goes until the end of the dataset.
778778
///
779779
/// See the other Range overload for a detailed description.
780-
TInterface<TDFDetail::TRange<Proxied>> Range(unsigned int stop) { return Range(0, stop, 1); }
780+
TInterface<TDFDetail::TRange<Proxied>> Range(unsigned int end) { return Range(0, end, 1); }
781781

782782
////////////////////////////////////////////////////////////////////////////
783783
/// \brief Execute a user-defined function on each entry (*instant action*)

0 commit comments

Comments
 (0)