Actually emit the API stability warning

Author: ncoghlan

src/lmstudio/plugin/cli.py

@@ -41,10 +41,6 @@ def main(argv: Sequence[str] | None = None) -> int:
         parser.print_usage()
         print(f"ERROR: Failed to find plugin folder at {plugin_path!r}")
         return 1
-    # TODO: Leave the warning enabled in the dev plugin wrapper
-    warnings.filterwarnings(
-        "ignore", ".*the plugin API is not yet stable", FutureWarning
-    )
     log_level = logging.DEBUG if args.debug else logging.INFO
     logging.basicConfig(level=log_level)
     if sys.platform == "win32":
@@ -61,6 +57,9 @@ def main(argv: Sequence[str] | None = None) -> int:
         if not SetConsoleCtrlHandler(None, 0):
             print("Failed to enable Ctrl-C events, termination may be abrupt")
     if not args.dev:
+        warnings.filterwarnings(
+            "ignore", ".*the plugin API is not yet stable", FutureWarning
+        )
         try:
             runner.run_plugin(plugin_path, allow_local_imports=True)
         except KeyboardInterrupt:

tests/test_plugin_examples.py

@@ -17,6 +17,8 @@
     _start_child_process,
     _PLUGIN_STOP_TIMEOUT,
 )
+from lmstudio.plugin.runner import _PLUGIN_API_STABILITY_WARNING
+
 
 _THIS_DIR = Path(__file__).parent.resolve()
 _PLUGIN_EXAMPLES_DIR = (_THIS_DIR / "../examples/plugins").resolve()
@@ -110,7 +112,19 @@ def _plugin_case_id(plugin_path: Path) -> str:
 @pytest.mark.parametrize("plugin_path", _get_plugin_paths(), ids=_plugin_case_id)
 def test_plugin_execution(plugin_path: Path) -> None:
     startup_lines, shutdown_lines, stderr_lines = _exec_and_interrupt(plugin_path)
+    # Stderr should start with the API stability warning...
+    warning_lines = [
+        *_PLUGIN_API_STABILITY_WARNING.splitlines(keepends=True),
+        "\n",
+        "warnings.warn(_PLUGIN_API_STABILITY_WARNING, FutureWarning)\n",
+    ]
+    for warning_line in warning_lines:
+        stderr_line = stderr_lines.pop(0)
+        assert stderr_line.endswith(warning_line)
+    # ... and then consist solely of logged information messages
     for log_line in stderr_lines:
         assert log_line.startswith("INFO:")
+    # Startup should finish with the notification of how to terminate the dev plugin
     assert startup_lines[-1].endswith("Ctrl-C to terminate...\n")
+    # Shutdown should finish with a graceful shutdown notice from the plugin runner
     assert shutdown_lines[-1] == "Plugin execution terminated by console interrupt\n"