Skip to content

Conversation

@carasen12
Copy link

No description provided.

tests/async2sync.py: tighten await regex, ensure sync output dir exists, and make commonpath usage robust.

misc/tag-release.sh: add strict mode, working-tree checks, duplicate-tag detection, and optional --push flag.

misc/update-sdk-schema.sh: add portable path resolution, CLI options (--branch, --no-pull), required-tool checks, and improved messages.
… misc/tag-release.sh with argument parsing, error handling, and push option. Refactored misc/update-sdk-schema.sh for better portability, argument parsing, and error checking. Updated tests/async2sync.py to use type annotations, fixed regex for 'await', ensured output directory creation, and improved path handling for compatibility.
@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@ncoghlan
Copy link
Collaborator

Thanks for the PR!

While these are at least potentially reasonable changes, they're also 4 sets of unrelated changes that don't belong in the same change set.

If you'd be willing to split it up into 4 separate PRs, those changes could be reviewed separately (although they may have other more specific concerns that would need to be considered on the individual PRs).

@github-actions github-actions bot added the CLA signed Indicates that all contributors have signed label Oct 17, 2025
@ncoghlan ncoghlan closed this Oct 17, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA signed Indicates that all contributors have signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants