Skip to content

Relax callback return type signatures #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Relax callback return type signatures #10

merged 1 commit into from
Feb 27, 2025

Conversation

@ncoghlan
Copy link
Collaborator

@ncoghlan ncoghlan commented Feb 27, 2025

  • When the SDK doesn't use the return value of a callback, mark the permitted return type as Any rather than None.
  • Define aliases for callback signatures used in multiple APIs

@ncoghlan
Relax callback return type signatures
9e1d3be 
* When the SDK doesn't use the return value of a callback,
  mark the permitted return type as `Any` rather than `None`.
* Define aliases for callback signatures used in multiple APIs
@github-actions github-actions bot added the CLA signed Indicates that all contributors have signed label Feb 27, 2025
@ncoghlan ncoghlan merged commit eec707a into main Feb 27, 2025
8 checks passed
@ncoghlan ncoghlan deleted the relax-callback-return-type-expectations branch February 27, 2025 12:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA signed Indicates that all contributors have signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ncoghlan