Websocket refactoring: allow lazy async connections #78
+706
−501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for migrating the async API over to using the AsyncWebsocketHandler API (instead of using the httpx-ws instance API directly), rework the task scheduling so the websocket handlers run inside one task group per client. Since the task manager's additional tasks group will own the handlers, it will no longer matter exactly which client coroutine triggers setting up the connection (once the async API migrates to the new imlementation interface). CI lock file updates are due to refactoring eliminating the dependency on the "exceptiongroups" project.
github-actions
bot
added
the
CLA signed
Collaborator
Author
|
Websocket shutdown workaround is due to frankie567/httpx-ws#107 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for migrating the async API over to using the AsyncWebsocketHandler API (instead of using the httpx-ws instance API directly), rework the task scheduling so the websocket handlers run inside one task group per client.
Since the task manager's additional tasks group will own the handlers, it will no longer matter exactly which client coroutine triggers setting up the connection (once the async API migrates to the new imlementation interface).
CI lock file updates are due to refactoring eliminating the dependency on the "exceptiongroups" project.