always check for mixed deref pattern and normal constructors

dianne · dianne · commit 127a4eff7186 · 2025-07-04T23:47:31.000-07:00
This makes it work for box patterns and in rust-analyzer.
diff --git a/crates/hir-ty/src/diagnostics/match_check/pat_analysis.rs b/crates/hir-ty/src/diagnostics/match_check/pat_analysis.rs
@@ -527,6 +527,14 @@ impl PatCx for MatchCheckCtx<'_> {
     fn complexity_exceeded(&self) -> Result<(), Self::Error> {
         Err(())
     }
+
+    fn report_mixed_deref_pat_ctors(
+        &self,
+        _deref_pat: &DeconstructedPat<'_>,
+        _normal_pat: &DeconstructedPat<'_>,
+    ) {
+        // FIXME(deref_patterns): This could report an error comparable to the one in rustc.
+    }
 }
 
 impl fmt::Debug for MatchCheckCtx<'_> {

Original file line number	Diff line number	Diff line change
`@@ -527,6 +527,14 @@ impl PatCx for MatchCheckCtx<'_> {`
`527`	`527`	`fn complexity_exceeded(&self) -> Result<(), Self::Error> {`
`528`	`528`	`Err(())`
`529`	`529`	`}`
	`530`	`+`
	`531`	`+ fn report_mixed_deref_pat_ctors(`
	`532`	`+ &self,`
	`533`	`+ _deref_pat: &DeconstructedPat<'_>,`
	`534`	`+ _normal_pat: &DeconstructedPat<'_>,`
	`535`	`+ ) {`
	`536`	`+ // FIXME(deref_patterns): This could report an error comparable to the one in rustc.`
	`537`	`+ }`
`530`	`538`	`}`
`531`	`539`
`532`	`540`	`impl fmt::Debug for MatchCheckCtx<'_> {`