Skip to content

Commit c6cc872

Browse files
committed
Change PI output bias to 32767 to workaround implementation bug
The 32768 offset was chosen as a 'half-scale' value for the DACs, but from my simulations it seems problematic (under certain conditions the voltage output became frozen even when the current error was large). The 32768 vs 32767 seems to suggest some signed arithmetic bug, but I didn't investigated it any further. It may fix an issue we observed in the field that sometimes after loading a new gateware some fast correctors would saturate and the only way to fix it was loading the gateware again.
1 parent e144d66 commit c6cc872

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

hdl/modules/rtmlamp_ohwr/rtmlamp_ohwr.vhd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,7 @@ begin
683683
generic map(
684684
g_error_bits => 16,
685685
g_dacval_bits => 16,
686-
g_output_bias => 32768,
686+
g_output_bias => 32767,
687687
g_integrator_fracbits => 16,
688688
g_integrator_overbits => 6,
689689
g_coef_bits => c_PI_COEFF_BITS

0 commit comments

Comments
 (0)