cargo-rail: cleaning it up

Author: loadingalias

deny.toml

@@ -16,7 +16,6 @@ ignore = []
 allow = [
   "MIT",
   "Apache-2.0",
-  "Apache-2.0 WITH LLVM-exception",
   "BSL-1.0",
   "Unicode-3.0",
   "Zlib",
@@ -30,12 +29,6 @@ wildcards = "allow"
 highlight = "all"
 
 skip = [
-  # Windows ecosystem - commonly has version mismatches across targets
-  "windows-sys",
-  "windows-targets",
-  "windows_aarch64_msvc",
-  "windows_x86_64_gnu",
-  "windows_x86_64_msvc",
   # Low-level system dependencies - acceptable to have multiple versions
   # petgraph depends on hashbrown v0.15, while indexmap uses v0.16
   "hashbrown",

src/commands/affected.rs

@@ -5,10 +5,10 @@
 //! - Which crates transitively depend on those changed crates
 //! - The minimal set of crates that need testing/building
 
-use crate::workspace::WorkspaceContext;
 use crate::error::{RailError, RailResult};
 use crate::git::SystemGit;
 use crate::graph::AffectedAnalysis;
+use crate::workspace::WorkspaceContext;
 use std::path::{Path, PathBuf};
 
 /// Output format for affected command

src/commands/check.rs

@@ -9,10 +9,10 @@
 //! - `--workspace` to override and check all workspace crates
 //! - `--dry-run` to show the plan without executing
 
-use crate::workspace::WorkspaceContext;
 use crate::error::{RailError, RailResult};
 use crate::git::SystemGit;
 use crate::graph::AffectedAnalysis;
+use crate::workspace::WorkspaceContext;
 use std::path::{Path, PathBuf};
 use std::process::Command;
 

src/commands/clippy.rs

@@ -9,10 +9,10 @@
 //! - `--workspace` to override and lint all workspace crates
 //! - `--dry-run` to show the plan without executing
 
-use crate::workspace::WorkspaceContext;
 use crate::error::{RailError, RailResult};
 use crate::git::SystemGit;
 use crate::graph::AffectedAnalysis;
+use crate::workspace::WorkspaceContext;
 use std::path::{Path, PathBuf};
 use std::process::Command;
 

src/commands/split.rs

@@ -1,10 +1,10 @@
 use std::io::{self, Write};
 
-use crate::workspace::WorkspaceContext;
 use crate::error::{ConfigError, RailError, RailResult};
 use crate::plan::PlanExecutor;
 use crate::plan::{Operation, OperationType, Plan};
 use crate::utils;
+use crate::workspace::WorkspaceContext;
 use rayon::prelude::*;
 
 /// Prompt user for confirmation

src/commands/status.rs

@@ -2,9 +2,9 @@ use serde::{Deserialize, Serialize};
 use std::path::PathBuf;
 use std::process::Command;
 
-use crate::workspace::WorkspaceContext;
 use crate::error::{RailError, RailResult};
 use crate::utils;
+use crate::workspace::WorkspaceContext;
 
 /// Status of a crate
 #[derive(Debug, Clone, Serialize, Deserialize)]

src/commands/sync.rs

@@ -1,9 +1,9 @@
-use crate::sync::{ConflictStrategy, SyncDirection};
-use crate::workspace::WorkspaceContext;
 use crate::error::{ConfigError, RailError, RailResult};
 use crate::plan::PlanExecutor;
 use crate::plan::{Operation, OperationType, Plan};
+use crate::sync::{ConflictStrategy, SyncDirection};
 use crate::utils;
+use crate::workspace::WorkspaceContext;
 use rayon::prelude::*;
 
 /// Sync command parameters

src/commands/test.rs

@@ -10,10 +10,10 @@
 //! - `--dry-run` to show the plan without executing
 //! - Parallel execution via rayon
 
-use crate::workspace::WorkspaceContext;
 use crate::error::{RailError, RailResult};
 use crate::git::SystemGit;
 use crate::graph::AffectedAnalysis;
+use crate::workspace::WorkspaceContext;
 use std::path::{Path, PathBuf};
 use std::process::Command;
 

src/config.rs

@@ -279,25 +279,6 @@ pub struct ReleaseConfig {
 }
 
 impl ReleaseConfig {
-  /// Check if this release has a split repo configured
-  pub fn has_split(&self) -> bool {
-    self.split.is_some()
-  }
-
-  /// Check if this is a new release (never released before)
-  pub fn is_first_release(&self) -> bool {
-    self.last_version.is_none() || self.last_sha.is_none()
-  }
-
-  /// Get the last version or default to "0.0.0"
-  pub fn current_version(&self) -> semver::Version {
-    self
-      .last_version
-      .as_ref()
-      .and_then(|v| semver::Version::parse(v).ok())
-      .unwrap_or_else(|| semver::Version::new(0, 0, 0))
-  }
-
   /// Validate release configuration
   pub fn validate(&self, workspace_root: &Path) -> RailResult<()> {
     // Validate crate path exists
@@ -410,30 +391,6 @@ impl RailConfig {
 
     Ok(config)
   }
-
-  /// Save config to rail.toml (default location)
-  pub fn save(&self, path: &Path) -> RailResult<()> {
-    let config_path = path.join("rail.toml");
-    let content = toml_edit::ser::to_string_pretty(self).context("Failed to serialize config to TOML")?;
-    fs::write(&config_path, content).with_context(|| format!("Failed to write config to {}", config_path.display()))?;
-    Ok(())
-  }
-
-  /// Check if config exists at the given path
-  pub fn exists(path: &Path) -> bool {
-    Self::find_config_path(path).is_some()
-  }
-
-  /// Create a new empty config
-  pub fn new(workspace_root: PathBuf) -> Self {
-    Self {
-      workspace: WorkspaceConfig { root: workspace_root },
-      security: SecurityConfig::default(),
-      policy: PolicyConfig::default(),
-      splits: Vec::new(),
-      releases: Vec::new(),
-    }
-  }
 }
 
 impl SplitConfig {

src/error.rs

@@ -15,8 +15,6 @@ pub enum ExitCode {
   User = 1,
   /// System error (git, network, I/O)
   System = 2,
-  /// Validation failure (checks failed, SSH, remotes)
-  Validation = 3,
 }
 
 impl ExitCode {
@@ -35,9 +33,6 @@ pub enum RailError {
   /// Git operation errors
   Git(GitError),
 
-  /// Validation errors (SSH, paths, etc.)
-  Validation(ValidationError),
-
   /// I/O errors
   Io(io::Error),
 
@@ -86,7 +81,6 @@ impl RailError {
     match self {
       RailError::Config(_) => ExitCode::User,
       RailError::Git(_) => ExitCode::System,
-      RailError::Validation(_) => ExitCode::Validation,
       RailError::Io(_) => ExitCode::System,
       RailError::Message { .. } => ExitCode::User,
     }
@@ -97,7 +91,6 @@ impl RailError {
     match self {
       RailError::Config(e) => e.help_message(),
       RailError::Git(e) => e.help_message(),
-      RailError::Validation(e) => e.help_message(),
       RailError::Message { help, .. } => help.clone(),
       _ => None,
     }
@@ -109,7 +102,6 @@ impl fmt::Display for RailError {
     match self {
       RailError::Config(e) => write!(f, "{}", e),
       RailError::Git(e) => write!(f, "{}", e),
-      RailError::Validation(e) => write!(f, "{}", e),
       RailError::Io(e) => write!(f, "I/O error: {}", e),
       RailError::Message { message, context, .. } => {
         write!(f, "{}", message)?;
@@ -315,42 +307,6 @@ impl fmt::Display for GitError {
   }
 }
 
-/// Validation errors
-#[derive(Debug)]
-pub enum ValidationError {
-  /// SSH key not found or invalid
-  SshKey { message: String },
-
-  /// Workspace validation failed
-  WorkspaceInvalid { reason: String },
-}
-
-impl ValidationError {
-  fn help_message(&self) -> Option<String> {
-    match self {
-      ValidationError::SshKey { .. } => {
-        Some("Create an SSH key with: ssh-keygen -t ed25519 -C \"[email protected]\"".to_string())
-      }
-      ValidationError::WorkspaceInvalid { .. } => {
-        Some("Run `cargo rail doctor` to diagnose workspace issues.".to_string())
-      }
-    }
-  }
-}
-
-impl fmt::Display for ValidationError {
-  fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-    match self {
-      ValidationError::SshKey { message } => {
-        write!(f, "SSH key validation failed: {}", message)
-      }
-      ValidationError::WorkspaceInvalid { reason } => {
-        write!(f, "Workspace validation failed: {}", reason)
-      }
-    }
-  }
-}
-
 /// Result type alias for cargo-rail
 pub type RailResult<T> = Result<T, RailError>;