carrgo-rail: wired JUnit reporting in CI; added a proper utils.rs for paths/urls/etc. across platforms

Author: loadingalias

.github/actions-lock.yaml

@@ -26,33 +26,36 @@
 actions/checkout:
   ref: v5.0.0
   sha: "08c6903cd8c0fde910a37f88322edcfb5dd907a8"
-  updated: "2025-01-11T00:00:00Z"
+  updated: "2025-11-15T04:25:54Z"
   notes: "Repository checkout - used in every workflow"
-
 actions/upload-artifact:
   ref: v5.0.0
   sha: "330a01c490aca151604b8cf639adc76d48f6c5d4"
-  updated: "2025-01-11T00:00:00Z"
+  updated: "2025-11-15T04:25:55Z"
   notes: "Upload build artifacts and test results"
-
+# ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+# Testing & Reporting
+# ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+mikepenz/action-junit-report:
+  ref: v6.0.1
+  sha: "e08919a3b1fb83a78393dfb775a9c37f17d8eea6"
+  updated: "2025-11-15T04:25:56Z"
+  notes: "Publish JUnit test reports as GitHub Checks"
 # ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 # Rust Toolchain & Ecosystem
 # ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-
 dtolnay/rust-toolchain:
   ref: master
-  sha: "6d653acede28d24f02e3cd41383119e8b1b35921"
-  updated: "2025-01-11T00:00:00Z"
+  sha: "0f44b27771c32bda9f458f75a1e241b09791b331"
+  updated: "2025-11-15T04:25:57Z"
   notes: "Rust toolchain installation - always tracks latest nightly"
-
 taiki-e/install-action:
   ref: v2
-  sha: "6f9c7cc51aa54b13cbcbd12f8bbf69d8ba405b4b"
-  updated: "2025-01-11T00:00:00Z"
+  sha: "0be4756f42223b67aa4b7df5effad59010cbf4b9"
+  updated: "2025-11-15T04:25:57Z"
   notes: "Install cargo tools (nextest, just, deny, audit)"
-
 Swatinem/rust-cache:
   ref: v2.8.1
   sha: "f13886b937689c021905a6b90929199931d60db1"
-  updated: "2025-01-11T00:00:00Z"
+  updated: "2025-11-15T04:25:58Z"
   notes: "GitHub runner Rust cache"

.github/actions/setup/action.yaml

@@ -15,37 +15,37 @@ runs:
     # Install cargo tools FIRST, before Rust toolchain installation
     # This prevents Windows issues where massive toolchain updates interfere with cargo bin directory
     - name: Install just
-      uses: taiki-e/install-action@6f9c7cc51aa54b13cbcbd12f8bbf69d8ba405b4b  # v2
+      uses: taiki-e/install-action@0be4756f42223b67aa4b7df5effad59010cbf4b9  # v2
       with:
         tool: just
 
     - name: Install cargo-nextest
-      uses: taiki-e/install-action@6f9c7cc51aa54b13cbcbd12f8bbf69d8ba405b4b  # v2
+      uses: taiki-e/install-action@0be4756f42223b67aa4b7df5effad59010cbf4b9  # v2
       with:
         tool: cargo-nextest
 
     - name: Install cargo-deny
-      uses: taiki-e/install-action@6f9c7cc51aa54b13cbcbd12f8bbf69d8ba405b4b  # v2
+      uses: taiki-e/install-action@0be4756f42223b67aa4b7df5effad59010cbf4b9  # v2
       with:
         tool: cargo-deny
 
     - name: Install cargo-audit
-      uses: taiki-e/install-action@6f9c7cc51aa54b13cbcbd12f8bbf69d8ba405b4b  # v2
+      uses: taiki-e/install-action@0be4756f42223b67aa4b7df5effad59010cbf4b9  # v2
       with:
         tool: cargo-audit
 
     - name: Install cargo-semver-checks
-      uses: taiki-e/install-action@6f9c7cc51aa54b13cbcbd12f8bbf69d8ba405b4b  # v2
+      uses: taiki-e/install-action@0be4756f42223b67aa4b7df5effad59010cbf4b9  # v2
       with:
         tool: cargo-semver-checks
 
     - name: Install git-cliff
-      uses: taiki-e/install-action@6f9c7cc51aa54b13cbcbd12f8bbf69d8ba405b4b  # v2
+      uses: taiki-e/install-action@0be4756f42223b67aa4b7df5effad59010cbf4b9  # v2
       with:
         tool: git-cliff
 
     - name: Install Rust Nightly Toolchain
-      uses: dtolnay/rust-toolchain@6d653acede28d24f02e3cd41383119e8b1b35921  # master
+      uses: dtolnay/rust-toolchain@0f44b27771c32bda9f458f75a1e241b09791b331  # master
       with:
         toolchain: nightly
         components: clippy, rustfmt

.github/workflows/commit.yaml

@@ -22,6 +22,8 @@ env:
 # Lock down permissions to read-only by default
 permissions:
   contents: read
+  checks: write  # Required for publishing test reports
+  pull-requests: write  # Required for PR comments on test results
 
 jobs:
   ci:
@@ -56,7 +58,9 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5.0.0
+        with:
+          persist-credentials: false
 
       - name: Setup
         uses: ./.github/actions/setup
@@ -72,11 +76,30 @@ jobs:
       - name: Tests
         run: just test
 
-      - name: Upload Test Results (on failure)
+      - name: Upload JUnit Test Report
+        if: always()
+        uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4  # v5.0.0
+        with:
+          name: junit-report-${{ matrix.target.name }}
+          path: junit.xml
+          retention-days: 7
+          if-no-files-found: ignore
+
+      - name: Publish Test Report
+        if: always()
+        uses: mikepenz/action-junit-report@e08919a3b1fb83a78393dfb775a9c37f17d8eea6  # v6.0.1
+        with:
+          report_paths: 'junit.xml'
+          check_name: 'Test Results (${{ matrix.target.name }})'
+          detailed_summary: true
+          include_passed: false
+          fail_on_failure: true
+
+      - name: Upload Nextest Results (on failure)
         if: failure()
-        uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
+        uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4  # v5.0.0
         with:
-          name: test-results-${{ matrix.target.name }}
+          name: nextest-results-${{ matrix.target.name }}
           path: target/nextest/
           retention-days: 7
           if-no-files-found: ignore

src/commands/split.rs

@@ -1,59 +1,15 @@
 use std::env;
 use std::io::{self, Write};
-use std::path::Path;
 
 use crate::commands::doctor;
 use crate::core::config::RailConfig;
 use crate::core::error::{ConfigError, RailError, RailResult};
 use crate::core::plan::{Operation, OperationType, Plan};
 use crate::core::split::{SplitConfig, Splitter};
 use crate::ui::progress::{FileProgress, MultiProgress};
+use crate::utils;
 use rayon::prelude::*;
 
-/// Check if a path is a local filesystem path (not a remote URL)
-///
-/// Returns true for:
-/// - Absolute paths on Unix: /path/to/repo
-/// - Absolute paths on Windows: C:\path\to\repo or C:/path/to/repo
-/// - Relative paths: ./path or ../path
-/// - UNC paths on Windows: \\server\share
-///
-/// Returns false for:
-/// - SSH URLs: [email protected]:user/repo.git
-/// - HTTPS URLs: <https://github.com/user/repo.git>
-fn is_local_path(path: &str) -> bool {
-  let p = Path::new(path);
-
-  // Check for relative paths
-  if path.starts_with("./") || path.starts_with("../") {
-    return true;
-  }
-
-  // Check for absolute paths (works on both Unix and Windows)
-  if p.is_absolute() {
-    return true;
-  }
-
-  // Check for Windows UNC paths (\\server\share)
-  #[cfg(target_os = "windows")]
-  if path.starts_with("\\\\") {
-    return true;
-  }
-
-  // If it contains :// it's a URL
-  if path.contains("://") {
-    return false;
-  }
-
-  // If it contains @ it's likely an SSH URL ([email protected]:user/repo.git)
-  if path.contains('@') {
-    return false;
-  }
-
-  // Default to false for safety (require preflight checks)
-  false
-}
-
 /// Prompt user for confirmation
 fn prompt_for_confirmation(message: &str) -> RailResult<bool> {
   print!("\n{}: ", message);
@@ -111,7 +67,7 @@ pub fn run_split(
   }
 
   // Check if all remotes are local paths (skip SSH checks for local testing)
-  let all_local = crates_to_split_check.iter().all(|s| is_local_path(&s.remote));
+  let all_local = crates_to_split_check.iter().all(|s| utils::is_local_path(&s.remote));
 
   // Run preflight health checks before proceeding (skip for local-only operations)
   if !json && apply && !all_local {

src/commands/sync.rs

@@ -1,5 +1,4 @@
 use std::env;
-use std::path::Path;
 
 use crate::commands::doctor;
 use crate::core::config::RailConfig;
@@ -8,52 +7,9 @@ use crate::core::error::{ConfigError, RailError, RailResult};
 use crate::core::plan::{Operation, OperationType, Plan};
 use crate::core::sync::{SyncConfig, SyncDirection, SyncEngine, SyncResult};
 use crate::ui::progress::{FileProgress, MultiProgress};
+use crate::utils;
 use rayon::prelude::*;
 
-/// Check if a path is a local filesystem path (not a remote URL)
-///
-/// Returns true for:
-/// - Absolute paths on Unix: /path/to/repo
-/// - Absolute paths on Windows: C:\path\to\repo or C:/path/to/repo
-/// - Relative paths: ./path or ../path
-/// - UNC paths on Windows: \\server\share
-///
-/// Returns false for:
-/// - SSH URLs: [email protected]:user/repo.git
-/// - HTTPS URLs: <https://github.com/user/repo.git>
-fn is_local_path(path: &str) -> bool {
-  let p = Path::new(path);
-
-  // Check for relative paths
-  if path.starts_with("./") || path.starts_with("../") {
-    return true;
-  }
-
-  // Check for absolute paths (works on both Unix and Windows)
-  if p.is_absolute() {
-    return true;
-  }
-
-  // Check for Windows UNC paths (\\server\share)
-  #[cfg(target_os = "windows")]
-  if path.starts_with("\\\\") {
-    return true;
-  }
-
-  // If it contains :// it's a URL
-  if path.contains("://") {
-    return false;
-  }
-
-  // If it contains @ it's likely an SSH URL ([email protected]:user/repo.git)
-  if path.contains('@') {
-    return false;
-  }
-
-  // Default to false for safety (require preflight checks)
-  false
-}
-
 /// Sync command parameters
 pub struct SyncParams {
   pub crate_name: Option<String>,
@@ -153,7 +109,7 @@ fn run_sync_impl(params: SyncParams) -> RailResult<()> {
   }
 
   // Check if all remotes are local paths (skip SSH checks for local testing)
-  let all_local = crates_to_sync_check.iter().all(|s| is_local_path(&s.remote));
+  let all_local = crates_to_sync_check.iter().all(|s| utils::is_local_path(&s.remote));
 
   // Run preflight health checks before proceeding (skip for local-only operations)
   if !json && apply && !all_local {

src/core/split.rs

@@ -10,6 +10,7 @@ use crate::core::mapping::MappingStore;
 use crate::core::security::SecurityValidator;
 use crate::core::vcs::CommitInfo;
 use crate::core::vcs::SystemGit;
+use crate::utils;
 
 /// Configuration for a split operation
 pub struct SplitConfig {
@@ -440,10 +441,7 @@ impl Splitter {
 
     // Push to remote if URL is configured and is not a local file path
     if let Some(ref remote_url) = config.remote_url {
-      // Check if this is a local file path (absolute path or relative)
-      let is_local_path = remote_url.starts_with('/') || remote_url.starts_with("./") || remote_url.starts_with("../");
-
-      if !remote_url.is_empty() && !is_local_path {
+      if !remote_url.is_empty() && !utils::is_local_path(remote_url) {
         println!("\n🚀 Pushing to remote...");
 
         // Security checks before push
@@ -470,7 +468,7 @@ impl Splitter {
         println!("   ✅ Pushed to {}", remote_url);
       } else {
         println!("\n💾 Split repository created locally");
-        if is_local_path {
+        if utils::is_local_path(remote_url) {
           println!("   Note: Remote is a local path, skipping push");
           println!(
             "   Local testing mode - split repo at: {}",