cargo-rail: cleaning out 'dead_code' or 'unused'. Fixing error messages. General cleanups.

Author: loadingalias

src/cargo/manifest_ops/fields.rs

@@ -63,7 +63,7 @@ pub fn set_features(item: &mut Item, features: Vec<String>) -> RailResult<()> {
     table.insert("features", Item::Value(build_feature_array(&features)));
     Ok(())
   } else {
-    Err(RailError::message("Cannot set features: item is not a table"))
+    Err(RailError::message("cannot set features: item is not a table"))
   }
 }
 
@@ -136,7 +136,7 @@ pub fn set_path(item: &mut Item, path: &str) -> RailResult<()> {
     table.insert("path", Item::Value(Value::from(path)));
     Ok(())
   } else {
-    Err(RailError::message("Cannot set path: item is not a table"))
+    Err(RailError::message("cannot set path: item is not a table"))
   }
 }
 
@@ -170,7 +170,7 @@ pub fn set_default_features(item: &mut Item, enabled: bool) -> RailResult<()> {
     table.insert("default-features", Item::Value(Value::from(enabled)));
     Ok(())
   } else {
-    Err(RailError::message("Cannot set default-features: item is not a table"))
+    Err(RailError::message("cannot set default-features: item is not a table"))
   }
 }
 

src/cargo/manifest_ops/navigation.rs

@@ -35,7 +35,7 @@ pub fn ensure_section(doc: &mut DocumentMut, path: &str) -> RailResult<()> {
         .ok_or_else(|| RailError::message(format!("Failed to access {}", part)))?;
     } else {
       return Err(RailError::message(
-        "Cannot create section: expected table but found non-table",
+        "cannot create section: expected table but found non-table",
       ));
     }
   }
@@ -77,7 +77,7 @@ pub fn get_or_create_table<'a>(doc: &'a mut DocumentMut, path: &str) -> RailResu
         .ok_or_else(|| RailError::message(format!("Failed to access {}", part)))?;
     } else {
       return Err(RailError::message(format!(
-        "Cannot navigate to {}: parent is not a table",
+        "cannot navigate to {}: parent is not a table",
         part
       )));
     }

src/cargo/manifest_ops/transform.rs

@@ -157,7 +157,7 @@ pub fn set_version(item: &mut Item, version: &str) -> RailResult<()> {
     Ok(())
   } else {
     Err(RailError::message(
-      "Cannot set version: item is not a valid dependency format",
+      "cannot set version: item is not a valid dependency format",
     ))
   }
 }
@@ -186,7 +186,7 @@ pub fn set_optional(item: &mut Item, optional: bool) -> RailResult<()> {
     table.insert("optional", Item::Value(Value::from(optional)));
     Ok(())
   } else {
-    Err(RailError::message("Cannot set optional: item is not a table"))
+    Err(RailError::message("cannot set optional: item is not a table"))
   }
 }
 

src/commands/clean.rs

@@ -24,16 +24,11 @@ pub fn run_clean(ctx: &WorkspaceContext, cache: bool, backups: bool, reports: bo
         .join("target")
         .join("cargo-rail")
         .join("metadata.json");
-      let old_cache = ctx.workspace_root.join("target").join("rail");
 
       if cache_path.exists() {
         println!("  {}", cache_path.display());
         would_clean = true;
       }
-      if old_cache.exists() {
-        println!("  {} (legacy)", old_cache.display());
-        would_clean = true;
-      }
     }
 
     if clean_reports {
@@ -111,23 +106,20 @@ pub fn run_clean(ctx: &WorkspaceContext, cache: bool, backups: bool, reports: bo
 }
 
 fn clean_metadata_cache(ctx: &WorkspaceContext) -> RailResult<()> {
-  let rail_target = ctx
+  let cache_path = ctx
     .workspace_root
     .join("target")
     .join("cargo-rail")
     .join("metadata.json");
-  let old_rail_target = ctx.workspace_root.join("target").join("rail");
 
-  if rail_target.exists() {
+  if cache_path.exists() {
     progress!("removing cache...");
-    fs::remove_file(&rail_target)
-      .map_err(|e| RailError::message(format!("failed to remove {}: {}", rail_target.display(), e)))?;
-  }
-
-  if old_rail_target.exists() {
-    progress!("removing legacy cache...");
-    fs::remove_dir_all(&old_rail_target)
-      .map_err(|e| RailError::message(format!("failed to remove {}: {}", old_rail_target.display(), e)))?;
+    fs::remove_file(&cache_path).map_err(|e| {
+      RailError::with_help(
+        format!("failed to remove {}: {}", cache_path.display(), e),
+        "check file permissions or if the file is in use",
+      )
+    })?;
   }
 
   Ok(())
@@ -138,12 +130,26 @@ fn clean_generated_reports(ctx: &WorkspaceContext) -> RailResult<()> {
 
   if report_dir.exists() {
     progress!("removing reports...");
-    for entry in fs::read_dir(&report_dir).map_err(|e| RailError::message(format!("failed to read dir: {}", e)))? {
-      let entry = entry.map_err(|e| RailError::message(format!("failed to read entry: {}", e)))?;
+    for entry in fs::read_dir(&report_dir).map_err(|e| {
+      RailError::with_help(
+        format!("failed to read {}: {}", report_dir.display(), e),
+        "check directory permissions",
+      )
+    })? {
+      let entry = entry.map_err(|e| {
+        RailError::with_help(
+          format!("failed to read directory entry: {}", e),
+          "check directory permissions",
+        )
+      })?;
       let path = entry.path();
       if path.is_file() && path.extension().is_some_and(|ext| ext == "md") {
-        fs::remove_file(&path)
-          .map_err(|e| RailError::message(format!("failed to remove {}: {}", path.display(), e)))?;
+        fs::remove_file(&path).map_err(|e| {
+          RailError::with_help(
+            format!("failed to remove {}: {}", path.display(), e),
+            "check file permissions or if the file is in use",
+          )
+        })?;
       }
     }
   }

src/commands/common.rs

@@ -136,7 +136,7 @@ impl<'a> SplitSyncConfigBuilder<'a> {
       self.with_crate(&name)
     } else {
       Err(RailError::with_help(
-        "Must specify a crate name or use --all",
+        "must specify a crate name or use --all",
         "Try: cargo rail <command> --all OR cargo rail <command> <crate-name>",
       ))
     }

src/commands/unify.rs

@@ -94,7 +94,14 @@ pub fn run_unify_analyze(
         if !dep.features.is_empty() {
           let mut features = dep.features.clone();
           features.sort();
-          println!("      features = {:?}", features);
+          println!(
+            "      features = [{}]",
+            features
+              .iter()
+              .map(|f| format!("\"{}\"", f))
+              .collect::<Vec<_>>()
+              .join(", ")
+          );
         }
       }
       println!();
@@ -135,7 +142,14 @@ pub fn run_unify_analyze(
             if !local_features.is_empty() {
               let mut features = local_features.clone();
               features.sort();
-              line.push_str(&format!(", features = {:?}", features));
+              line.push_str(&format!(
+                ", features = [{}]",
+                features
+                  .iter()
+                  .map(|f| format!("\"{}\"", f))
+                  .collect::<Vec<_>>()
+                  .join(", ")
+              ));
             }
             if *is_optional {
               line.push_str(", optional = true");

src/config/mod.rs

@@ -201,8 +201,7 @@ impl RailConfig {
       .collect()
   }
 
-  /// Helper to build all SplitConfigs from unified crate config
-  /// Used for backward compatibility with commands expecting `Vec<SplitConfig>`
+  /// Build all SplitConfigs from unified crate config
   pub fn build_split_configs(&self) -> Vec<SplitConfig> {
     self
       .crates

src/config/release.rs

@@ -139,7 +139,7 @@ pub struct ChangelogConfig {
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Default, Serialize, Deserialize)]
 #[serde(rename_all = "lowercase")]
 pub enum ChangelogRelativeTo {
-  /// Relative to each crate's directory (default, backward compatible)
+  /// Relative to each crate's directory (default)
   /// With this, `changelog_path = "CHANGELOG.md"` creates `crates/foo/CHANGELOG.md`
   #[default]
   Crate,
@@ -210,7 +210,7 @@ mod tests {
 
   #[test]
   fn test_changelog_relative_to_defaults_to_crate() {
-    // When not specified, should default to "crate" for backward compatibility
+    // When not specified, should default to "crate"
     let toml = r#"
       changelog_path = "CHANGELOG.md"
     "#;

src/config/unify.rs

@@ -12,7 +12,7 @@ pub struct UnifyConfig {
 
   /// Handle renamed dependencies (package = "...")? (default: false)
   /// Renamed deps are tricky to unify correctly, opt-in only
-  #[serde(default, alias = "allow_renamed")]
+  #[serde(default)]
   pub include_renamed: bool,
 
   /// Pin transitive-only deps with fragmented features? (default: true)
@@ -170,7 +170,7 @@ impl<'de> Deserialize<'de> for TransitiveFeatureHost {
         E: serde::de::Error,
       {
         match value {
-          "root" | "auto" => Ok(TransitiveFeatureHost::Root), // "auto" for backward compatibility
+          "root" => Ok(TransitiveFeatureHost::Root),
           path => Ok(TransitiveFeatureHost::Path(path.to_string())),
         }
       }

src/git/ops.rs

@@ -23,8 +23,7 @@ impl SystemGit {
   ///
   /// Returns commits in reverse chronological order (newest first).
   /// Uses parallel batch processing for optimal performance.
-  /// The _path parameter is kept for API compatibility but currently unused.
-  pub fn commit_history(&self, _path: &Path, limit: Option<usize>) -> RailResult<Vec<CommitInfo>> {
+  pub fn commit_history(&self, limit: Option<usize>) -> RailResult<Vec<CommitInfo>> {
     let mut args = vec!["log", "--format=%H"];
     let limit_str;
     if let Some(max) = limit {
@@ -619,7 +618,7 @@ mod tests {
     let git = SystemGit::open(&find_git_root()).unwrap();
 
     // Test with limit
-    let commits = git.commit_history(Path::new("."), Some(5)).unwrap();
+    let commits = git.commit_history(Some(5)).unwrap();
     assert!(!commits.is_empty());
     assert!(commits.len() <= 5);
 
@@ -653,7 +652,7 @@ mod tests {
     let git = SystemGit::open(&find_git_root()).unwrap();
 
     // Get some commit SHAs
-    let history = git.commit_history(Path::new("."), Some(5)).unwrap();
+    let history = git.commit_history(Some(5)).unwrap();
     let shas: Vec<String> = history.iter().map(|c| c.sha.clone()).collect();
 
     // Fetch them in bulk