cargo-rail: fixing the junit paths/config; fixing the Windows path issues still.

Author: loadingalias

.config/nextest.toml

@@ -18,3 +18,6 @@ retries = { backoff = "exponential", count = 2, delay = "1s", jitter = true }
 
 [profile.commit.junit]
 path = "junit.xml"
+report-name = "cargo-rail-tests"
+store-success-output = false
+store-failure-output = true

.github/workflows/commit.yaml

@@ -81,19 +81,22 @@ jobs:
         uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4  # v5.0.0
         with:
           name: junit-report-${{ matrix.target.name }}
-          path: junit.xml
+          path: target/nextest/commit/junit.xml
           retention-days: 7
           if-no-files-found: ignore
 
       - name: Publish Test Report
         if: always()
         uses: mikepenz/action-junit-report@e08919a3b1fb83a78393dfb775a9c37f17d8eea6  # v6.0.1
         with:
-          report_paths: 'junit.xml'
+          report_paths: 'target/nextest/commit/junit.xml'
           check_name: 'Test Results (${{ matrix.target.name }})'
           detailed_summary: true
           include_passed: false
           fail_on_failure: true
+          require_tests: true
+          annotate_only: false
+          summary: true
 
       - name: Upload Nextest Results (on failure)
         if: failure()

src/checks/remotes.rs

@@ -4,6 +4,7 @@ use super::trait_def::{Check, CheckContext, CheckResult};
 use crate::core::config::RailConfig;
 use crate::core::error::RailResult;
 use crate::ui::progress::FileProgress;
+use crate::utils;
 use std::process::Command;
 
 /// Check that validates remote repository accessibility
@@ -137,7 +138,7 @@ fn is_valid_remote_url(url: &str) -> bool {
   }
 
   // Local path (absolute or relative)
-  if url.starts_with('/') || url.starts_with("./") || url.starts_with("../") {
+  if utils::is_local_path(url) {
     return true;
   }
 
@@ -147,7 +148,7 @@ fn is_valid_remote_url(url: &str) -> bool {
 /// Test if we can access a remote repository
 fn test_remote_access(url: &str) -> RailResult<bool> {
   // For local paths, just check if directory exists
-  if url.starts_with('/') || url.starts_with("./") || url.starts_with("../") {
+  if utils::is_local_path(url) {
     let path = std::path::Path::new(url);
     return Ok(path.exists());
   }

src/commands/mappings.rs

@@ -6,6 +6,7 @@ use crate::core::config::RailConfig;
 use crate::core::error::{ConfigError, RailError, RailResult};
 use crate::core::mapping::MappingStore;
 use crate::ui::progress::FileProgress;
+use crate::utils;
 
 /// A single SHA mapping
 #[derive(Debug, Clone, Serialize, Deserialize)]
@@ -176,10 +177,7 @@ fn get_target_path(
   current_dir: &std::path::Path,
   split_config: &crate::core::config::SplitConfig,
 ) -> Option<std::path::PathBuf> {
-  let target_repo_path = if split_config.remote.starts_with('/')
-    || split_config.remote.starts_with("./")
-    || split_config.remote.starts_with("../")
-  {
+  let target_repo_path = if utils::is_local_path(&split_config.remote) {
     std::path::PathBuf::from(&split_config.remote)
   } else {
     let remote_name = split_config

src/commands/split.rs

@@ -129,10 +129,7 @@ pub fn run_split(
     let crate_paths = split_config.get_paths().into_iter().cloned().collect::<Vec<_>>();
 
     // Determine target repo path
-    let target_repo_path = if split_config.remote.starts_with('/')
-      || split_config.remote.starts_with("./")
-      || split_config.remote.starts_with("../")
-    {
+    let target_repo_path = if utils::is_local_path(&split_config.remote) {
       std::path::PathBuf::from(&split_config.remote)
     } else {
       let remote_name = split_config

src/commands/status.rs

@@ -5,6 +5,7 @@ use std::process::Command;
 
 use crate::core::config::RailConfig;
 use crate::core::error::{ConfigError, RailError, RailResult};
+use crate::utils;
 
 /// Status of a crate
 #[derive(Debug, Clone, Serialize, Deserialize)]
@@ -71,10 +72,7 @@ pub fn run_status(json: bool) -> RailResult<()> {
   let mut statuses = Vec::new();
 
   for split_config in &config.splits {
-    let target_repo_path = if split_config.remote.starts_with('/')
-      || split_config.remote.starts_with("./")
-      || split_config.remote.starts_with("../")
-    {
+    let target_repo_path = if utils::is_local_path(&split_config.remote) {
       std::path::PathBuf::from(&split_config.remote)
     } else {
       let remote_name = split_config

src/commands/sync.rs

@@ -187,10 +187,7 @@ fn run_sync_impl(params: SyncParams) -> RailResult<()> {
     let crate_paths = split_config.get_paths().into_iter().cloned().collect::<Vec<_>>();
 
     // Determine target repo path
-    let target_repo_path = if split_config.remote.starts_with('/')
-      || split_config.remote.starts_with("./")
-      || split_config.remote.starts_with("../")
-    {
+    let target_repo_path = if utils::is_local_path(&split_config.remote) {
       std::path::PathBuf::from(&split_config.remote)
     } else {
       let remote_name = split_config

src/utils.rs

@@ -35,7 +35,17 @@ pub fn is_local_path(path: &str) -> bool {
     return true;
   }
 
-  // Check for absolute paths (works on Unix, and Windows on Windows)
+  // Check for Unix absolute paths (/path/to/repo)
+  // Important: Check this BEFORE is_absolute() because on Windows,
+  // Path::is_absolute() returns false for Unix-style paths
+  if path.starts_with('/') {
+    // Make sure it's not part of a URL pattern
+    if !path.contains("://") && !path.contains('@') {
+      return true;
+    }
+  }
+
+  // Check for absolute paths (fallback for platform-specific cases)
   if p.is_absolute() {
     return true;
   }

tests/integration/test_split.rs

@@ -21,7 +21,7 @@ fn test_split_creates_repo_with_history() -> Result<()> {
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
 
   // Run split with remote override
-  let split_dir = workspace.path.join("split-repos/my-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("my-crate-split");
   run_cargo_rail(
     &workspace.path,
     &[
@@ -74,7 +74,7 @@ fn test_split_transforms_cargo_toml() -> Result<()> {
 
   // Initialize and split app-crate with remote override
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/app-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("app-crate-split");
   run_cargo_rail(
     &workspace.path,
     &[
@@ -124,7 +124,7 @@ fn test_split_filters_commits() -> Result<()> {
 
   // Initialize and split crate-a with remote override
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/crate-a-split");
+  let split_dir = workspace.path.join("split-repos").join("crate-a-split");
   run_cargo_rail(
     &workspace.path,
     &[
@@ -169,7 +169,7 @@ fn test_split_copies_auxiliary_files() -> Result<()> {
 
   // Initialize and split with remote override
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/my-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("my-crate-split");
   run_cargo_rail(
     &workspace.path,
     &[

tests/integration/test_sync.rs

@@ -12,7 +12,7 @@ fn test_sync_mono_to_remote() -> Result<()> {
   workspace.commit("Add my-crate")?;
 
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/my-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("my-crate-split");
   run_cargo_rail(
     &workspace.path,
     &[
@@ -65,7 +65,7 @@ fn test_sync_remote_to_mono() -> Result<()> {
   workspace.commit("Add my-crate")?;
 
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/my-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("my-crate-split");
   run_cargo_rail(
     &workspace.path,
     &[
@@ -121,7 +121,7 @@ fn test_sync_bidirectional() -> Result<()> {
   workspace.commit("Add my-crate")?;
 
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/my-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("my-crate-split");
   run_cargo_rail(
     &workspace.path,
     &[
@@ -190,7 +190,7 @@ fn test_sync_deduplicates_commits() -> Result<()> {
   workspace.commit("Add my-crate")?;
 
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/my-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("my-crate-split");
   run_cargo_rail(
     &workspace.path,
     &[
@@ -254,7 +254,7 @@ fn test_conflict_resolution_ours_strategy() -> Result<()> {
   workspace.commit("Add my-crate")?;
 
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/my-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("my-crate-split");
 
   run_cargo_rail(
     &workspace.path,
@@ -334,7 +334,7 @@ fn test_conflict_resolution_theirs_strategy() -> Result<()> {
   workspace.commit("Add my-crate")?;
 
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/my-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("my-crate-split");
 
   run_cargo_rail(
     &workspace.path,
@@ -410,7 +410,7 @@ fn test_conflict_resolution_manual_strategy() -> Result<()> {
   workspace.commit("Add my-crate")?;
 
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/my-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("my-crate-split");
 
   run_cargo_rail(
     &workspace.path,
@@ -487,7 +487,7 @@ fn test_conflict_resolution_union_strategy() -> Result<()> {
   workspace.commit("Add my-crate")?;
 
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/my-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("my-crate-split");
 
   run_cargo_rail(
     &workspace.path,
@@ -567,7 +567,7 @@ fn test_no_conflict_with_non_overlapping_changes() -> Result<()> {
   workspace.commit("Add my-crate")?;
 
   run_cargo_rail(&workspace.path, &["rail", "init", "--all"])?;
-  let split_dir = workspace.path.join("split-repos/my-crate-split");
+  let split_dir = workspace.path.join("split-repos").join("my-crate-split");
   run_cargo_rail(
     &workspace.path,
     &[