Skip to content

Commit f3b5883

Browse files
Merge pull request #6 from loadsmart/dealWithMissingSubject
Return none if no subject set
2 parents ba01199 + 62f7da9 commit f3b5883

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

gmail_wrapper/entities.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def id(self):
7979

8080
@property
8181
def subject(self):
82-
return self.headers["Subject"]
82+
return self.headers.get("Subject")
8383

8484
@property
8585
def date(self):

tests/test_entities.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ def test_it_fetch_additional_information_when_needed(
3535
)
3636
mocked_get_raw_message.assert_called_once_with(raw_incomplete_message["id"])
3737

38+
def test_it_return_none_if_no_subject_header(self, client, raw_complete_message):
39+
del raw_complete_message["payload"]["headers"][2]
40+
message = Message(client, raw_complete_message)
41+
assert message.subject is None
42+
3843
def test_get_labels(
3944
self, mocker, raw_complete_message, client, raw_incomplete_message
4045
):

0 commit comments

Comments
 (0)