-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
🐛 fix: restore history count control in chat input action bar #11319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The history (context turn limit) button was missing from the chat input action bar in the next branch. Added 'history' action to leftActions in: - chat/MainChatInput - group/MainChatInput - group/GroupChat This restores the ability to control conversation context history limit that was available in previous versions.
|
@Ricky-Hao is attempting to deploy a commit to the LobeHub OSS Team on Vercel. A member of the Team first needs to authorize it. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRestores the missing history/context-turn-limit control in the chat input action bar for both direct and group conversations by reintroducing the Flow diagram for history action in leftActions configurationflowchart LR
User[User] --> ChatInputUI[ChatInputActionBar]
ChatInputUI --> LeftActionsConfig[leftActions_configuration]
LeftActionsConfig --> HistoryAction[history_action_button]
HistoryAction --> ContextLimitModal[Context_turn_limit_controls]
ContextLimitModal --> UpdatedSettings[Updated_conversation_context_limit]
subgraph DirectChat
DCFile[src_app_chat_MainChatInput_index_tsx]
DCFile --> LeftActionsConfig
end
subgraph GroupChat
GCMain[src_app_group_MainChatInput_index_tsx]
GCChat[src_app_group_MainChatInput_GroupChat_tsx]
GCMain --> LeftActionsConfig
GCChat --> LeftActionsConfig
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
TestGru AssignmentSummary
Tip You can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Since the
leftActionsconfiguration is now duplicated across three components, consider extracting this array (or the common portion of it) into a shared constant/helper to keep the action set in sync and avoid regressions like the missinghistoryaction in the future.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the `leftActions` configuration is now duplicated across three components, consider extracting this array (or the common portion of it) into a shared constant/helper to keep the action set in sync and avoid regressions like the missing `history` action in the future.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
The history (context turn limit) button was missing from the chat input action bar in the next branch. Added 'history' action to leftActions in:
This restores the ability to control conversation context history limit that was available in previous versions.
💻 Change Type
🔗 Related Issue
🔀 Description of Change
🧪 How to Test
📸 Screenshots / Videos
📝 Additional Information
Summary by Sourcery
Bug Fixes: